All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Steigerwald <Martin@lichtvoll.de>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: David Sterba <dave@jikos.cz>,
	linux-btrfs@vger.kernel.org, jbacik@fusionio.com
Subject: Re: 3.5-rc4: BTRFS unmountable after hard lockup
Date: Tue, 26 Jun 2012 14:28:47 +0200	[thread overview]
Message-ID: <201206261428.48262.Martin@lichtvoll.de> (raw)
In-Reply-To: <4FE930D5.3050505@cn.fujitsu.com>

Am Dienstag, 26. Juni 2012 schrieb Liu Bo:
> On 06/26/2012 06:18 AM, David Sterba wrote:
> > 3756         if (root->fs_info->log_root_recovering) {
> > 3757                 BUG_ON(!test_bit(BTRFS_INODE_HAS_ORPHAN_ITEM,
> > 3758                                 &BTRFS_I(inode)->runtime_flags)); 
> > 3759                 goto no_delete;
> > 3760         }
> > 
> > and it happened during log replay, as you found already, fixable by
> > running the zero-log utility. Another way is to mount read-only, this
> > skips log replay.
> > 
> > I think there could be a logic error, as this probably happens only
> > during log replay when the orphan bit is not in sync with link count,
> > but I saw that this should be handled in the fixup_inode_link_counts
> > call path. CCing Josef, if he has an idea.
> 
> It is a logic error, but mostly a finger wrong from Josef IMO... :)
> 
> I'll send a patch for it.

Thanks for looking into it. 

Since my BTRFS is up and running again I can´t test a patch easily however.
I´d have to unplug the disk or crash my laptop several times to trigger it
again I bet.

-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7

  reply	other threads:[~2012-06-26 12:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 18:29 3.5-rc4: BTRFS unmountable after hard lockup Martin Steigerwald
2012-06-25 18:48 ` Martin Steigerwald
2012-06-25 22:18 ` David Sterba
2012-06-26  3:47   ` Liu Bo
2012-06-26 12:28     ` Martin Steigerwald [this message]
2012-06-26 12:49     ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206261428.48262.Martin@lichtvoll.de \
    --to=martin@lichtvoll.de \
    --cc=dave@jikos.cz \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=liubo2009@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.