From mboxrd@z Thu Jan  1 00:00:00 1970
From: "J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH 1/1] locks: prevent side-effects of
 locks_release_private before file_lock is initialized
Date: Tue, 26 Jun 2012 11:23:37 -0400
Message-ID: <20120626152336.GD14279@fieldses.org>
References: <1339815965-1171-1-git-send-email-filbranden@gmail.com>
 <1339815965-1171-2-git-send-email-filbranden@gmail.com>
 <20120618200131.GA12351@fieldses.org>
 <CABe66sW0k4N_7vMduOZMRak-U4A+6E7i+fiGwKEVBazJ1npBeg@mail.gmail.com>
 <20120626002908.GA14279@fieldses.org>
 <CABe66sV=coC3=-CU1uDrCfN7aucKg59emTZZS=kL41OwYyrNBw@mail.gmail.com>
 <CABe66sXc6tD83D=w_=YeNBo-5A7Q_KPTCq1-Dfnk9JCNw0i5ug@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Al Viro <viro@zeniv.linux.org.uk>, Matthew Wilcox <matthew@wil.cx>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Filipe Brandenburger <filbranden@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CABe66sXc6tD83D=w_=YeNBo-5A7Q_KPTCq1-Dfnk9JCNw0i5ug@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, Jun 25, 2012 at 10:10:35PM -0400, Filipe Brandenburger wrote:
> Just to let you know that I just tested the patch below on top of
> 3.5.0-rc4 and it works fine...
> 
> Do you like the idea of this second patch or do you prefer the
> __locks_free_lock() one?

Like I said:

> Let's just go with your first patch and free the thing by hand (but
> add a comment explaining why).
> 
> Then come back and figure out how to make the interface clearer once
> we've got the bug fixed.

--b.