All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Junio C Hamano <gitster@pobox.com>,
	David Barr <david.barr@cordelta.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] t9010: Open backflow FIFO once to work around kernel race condition
Date: Tue, 26 Jun 2012 17:40:53 -0500	[thread overview]
Message-ID: <20120626224053.GA7155@burratino> (raw)
In-Reply-To: <1340749806-22734-1-git-send-email-andersk@mit.edu>

Hi,

Quick first impressions:

Anders Kaseorg wrote:

> Sidestep this problem by opening the backflow FIFO once for
> read+write.

Is that portable?

>             Also, replace the stream FIFO with a shell pipe so we
> don’t have to do manual process management.

Doesn't this mean we wouldn't notice if test-svn-fe crashes?

Maybe it would be simpler to make test-svn-fe launch fast-import as a
child, avoiding the fifos altogether.

Thanks again for tracking this down, by the way.
Jonathan

  reply	other threads:[~2012-06-26 22:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 22:30 [PATCH] t9010: Open backflow FIFO once to work around kernel race condition Anders Kaseorg
2012-06-26 22:40 ` Jonathan Nieder [this message]
2012-06-26 22:46   ` Anders Kaseorg
2012-06-26 22:58   ` Junio C Hamano
2012-06-26 23:08   ` Stefano Lattarini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120626224053.GA7155@burratino \
    --to=jrnieder@gmail.com \
    --cc=andersk@MIT.EDU \
    --cc=david.barr@cordelta.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.