All of lore.kernel.org
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 02/14] usb: chipidea: drop useless arch-check
Date: Tue, 26 Jun 2012 23:52:06 +0200	[thread overview]
Message-ID: <201206262352.07387.marex@denx.de> (raw)
In-Reply-To: <1340607391-16380-3-git-send-email-richard.zhao@freescale.com>

Dear Richard Zhao,

> From: Felipe Balbi <balbi@ti.com>
> 
> msm glue layer compiles on all arches just
> fine. Let's drop the unnecessary ARCH check
> so we have easier compile tests.
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>

Good move

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  drivers/usb/chipidea/Makefile |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
> index cc34937..b69900a 100644
> --- a/drivers/usb/chipidea/Makefile
> +++ b/drivers/usb/chipidea/Makefile
> @@ -5,10 +5,12 @@ ci_hdrc-$(CONFIG_USB_CHIPIDEA_UDC)	+= udc.o
>  ci_hdrc-$(CONFIG_USB_CHIPIDEA_HOST)	+= host.o
>  ci_hdrc-$(CONFIG_USB_CHIPIDEA_DEBUG)	+= debug.o
> 
> +# Glue/Bridge layers go here
> +
> +obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_msm.o
> +
> +# PCI doesn't provide stubs, need to check
>  ifneq ($(CONFIG_PCI),)
>  	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_pci.o
>  endif
> 
> -ifneq ($(CONFIG_ARCH_MSM),)
> -	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_msm.o
> -endif

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Richard Zhao <richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
	linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH v7 02/14] usb: chipidea: drop useless arch-check
Date: Tue, 26 Jun 2012 23:52:06 +0200	[thread overview]
Message-ID: <201206262352.07387.marex@denx.de> (raw)
In-Reply-To: <1340607391-16380-3-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Dear Richard Zhao,

> From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> 
> msm glue layer compiles on all arches just
> fine. Let's drop the unnecessary ARCH check
> so we have easier compile tests.
> 
> Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Alexander Shishkin <alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

Good move

Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>

> ---
>  drivers/usb/chipidea/Makefile |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
> index cc34937..b69900a 100644
> --- a/drivers/usb/chipidea/Makefile
> +++ b/drivers/usb/chipidea/Makefile
> @@ -5,10 +5,12 @@ ci_hdrc-$(CONFIG_USB_CHIPIDEA_UDC)	+= udc.o
>  ci_hdrc-$(CONFIG_USB_CHIPIDEA_HOST)	+= host.o
>  ci_hdrc-$(CONFIG_USB_CHIPIDEA_DEBUG)	+= debug.o
> 
> +# Glue/Bridge layers go here
> +
> +obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_msm.o
> +
> +# PCI doesn't provide stubs, need to check
>  ifneq ($(CONFIG_PCI),)
>  	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_pci.o
>  endif
> 
> -ifneq ($(CONFIG_ARCH_MSM),)
> -	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_msm.o
> -endif

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-06-26 21:52 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25  6:56 [PATCH v7 00/14] add imx usb driver based on Greg next tree Richard Zhao
2012-06-25  6:56 ` Richard Zhao
2012-06-25  6:56 ` [PATCH v7 01/14] usb: chipidea: remove unneeded NULL check Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-26 21:43   ` Greg KH
2012-06-26 21:43     ` Greg KH
2012-06-27  6:24     ` Richard Zhao
2012-06-27  6:24       ` Richard Zhao
2012-06-26 21:51   ` Marek Vasut
2012-06-26 21:51     ` Marek Vasut
2012-06-25  6:56 ` [PATCH v7 02/14] usb: chipidea: drop useless arch-check Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-26 21:52   ` Marek Vasut [this message]
2012-06-26 21:52     ` Marek Vasut
2012-06-25  6:56 ` [PATCH v7 03/14] usb: chipidea: msm: add missing section annotation Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-26 21:52   ` Marek Vasut
2012-06-26 21:52     ` Marek Vasut
2012-06-25  6:56 ` [PATCH v7 04/14] usb: chipidea: msm: add remove method Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-25 13:18   ` ABRAHAM, KISHON VIJAY
2012-06-25 13:18     ` ABRAHAM, KISHON VIJAY
2012-06-25 13:33     ` Marek Vasut
2012-06-25 13:33       ` Marek Vasut
2012-06-25 13:44       ` ABRAHAM, KISHON VIJAY
2012-06-25 13:44         ` ABRAHAM, KISHON VIJAY
2012-06-25 13:55         ` Marek Vasut
2012-06-25 13:55           ` Marek Vasut
2012-06-25 14:14           ` Felipe Balbi
2012-06-25 14:14             ` Felipe Balbi
2012-06-25 14:20             ` Marek Vasut
2012-06-25 14:20               ` Marek Vasut
2012-06-25  6:56 ` [PATCH v7 05/14] USB: Chipidea: rename struct ci13xxx_udc_driver to struct ci13xxx_platform_data Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-26 21:54   ` Marek Vasut
2012-06-26 21:54     ` Marek Vasut
2012-06-27  6:30     ` Richard Zhao
2012-06-27  6:30       ` Richard Zhao
2012-06-25  6:56 ` [PATCH v7 06/14] USB: Chipidea: rename struct ci13xxx variables from udc to ci Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-26 21:55   ` Marek Vasut
2012-06-26 21:55     ` Marek Vasut
2012-06-27 12:42   ` Marc Kleine-Budde
2012-06-27 12:42     ` Marc Kleine-Budde
2012-06-28  1:59     ` Richard Zhao
2012-06-28  1:59       ` Richard Zhao
2012-06-25  6:56 ` [PATCH v7 07/14] USB: Chipidea: add unified ci13xxx_{add, remove}_device for platform drivers Richard Zhao
2012-06-25  6:56   ` [PATCH v7 07/14] USB: Chipidea: add unified ci13xxx_{add,remove}_device " Richard Zhao
2012-06-25  6:56 ` [PATCH v7 08/14] USB: Chipidea: add ci13xxx device id management Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-25  9:48   ` Marc Kleine-Budde
2012-06-25  9:48     ` Marc Kleine-Budde
2012-06-25 10:03     ` Richard Zhao
2012-06-25 10:03       ` Richard Zhao
2012-06-25 10:17       ` Marc Kleine-Budde
2012-06-25 10:17         ` Marc Kleine-Budde
2012-06-27  5:42         ` Richard Zhao
2012-06-27  5:42           ` Richard Zhao
2012-06-27 11:49           ` Marek Vasut
2012-06-27 11:49             ` Marek Vasut
2012-06-27 12:02             ` Marc Kleine-Budde
2012-06-27 12:02               ` Marc Kleine-Budde
2012-06-25  6:56 ` [PATCH v7 09/14] usb: chipidea: select USB_EHCI_ROOT_HUB_TT in USB_CHIPIDEA_HOST of Kconfig Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-26 21:58   ` Marek Vasut
2012-06-26 21:58     ` Marek Vasut
2012-06-25  6:56 ` [PATCH v7 10/14] usb: otg: add notify_connect/notify_disconnect callback Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-25  6:56 ` [PATCH v7 11/14] USB: notify phy when root hub port connect change Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-25  6:56 ` [PATCH v7 12/14] usb: chipidea: permit driver bindings pass phy pointer Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-25  6:56 ` [PATCH v7 13/14] usb: otg: add basic mxs phy driver support Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-27  6:37   ` Richard Zhao
2012-06-27  6:37     ` Richard Zhao
2012-06-25  6:56 ` [PATCH v7 14/14] usb: chipidea: add imx platform driver Richard Zhao
2012-06-25  6:56   ` Richard Zhao
2012-06-25 10:33   ` Marc Kleine-Budde
2012-06-25 10:33     ` Marc Kleine-Budde
2012-06-27  6:20     ` Richard Zhao
2012-06-27  6:20       ` Richard Zhao
2012-06-27  9:46       ` Marc Kleine-Budde
2012-06-27  9:46         ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206262352.07387.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.