From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 06/12] 8250: use the 8250 register interface not the legacy one
Date: Tue, 26 Jun 2012 19:30:24 -0700 [thread overview]
Message-ID: <20120627023024.GA13576@kroah.com> (raw)
In-Reply-To: <20120622154333.1405.21372.stgit@localhost.localdomain>
On Fri, Jun 22, 2012 at 04:43:51PM +0100, Alan Cox wrote:
> @@ -69,7 +69,6 @@ struct uart_port;
> struct uart_8250_port;
>
> int serial8250_register_8250_port(struct uart_8250_port *);
> -int serial8250_register_port(struct uart_port *);
There are still in-kernel callers of this function, so I don't think
it's safe to remove just yet, otherwise the build will break:
drivers/char/mwave/mwavedd.c: return serial8250_register_port(&uart);
drivers/misc/ibmasm/uart.c: sp->serial_line = serial8250_register_port(&uport);
drivers/net/ethernet/sgi/ioc3-eth.c: serial8250_register_port(&port);
drivers/tty/serial/of_serial.c: ret = serial8250_register_port(&port);
I'm stopping here on this series, I've only applied the one that added
the comment, that seems to be the only one that compiled properly :(
Care to redo these please?
thanks,
greg k-h
next prev parent reply other threads:[~2012-06-27 2:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 15:36 [PATCH 01/12] f81232: correct stubbed termios handler Alan Cox
2012-06-22 15:38 ` [PATCH 02/12] usb: fix sillies in the metro USB driver Alan Cox
2012-06-24 21:49 ` Jiri Slaby
2012-07-23 16:32 ` Alan Cox
2012-06-22 15:40 ` [PATCH 03/12] tty: note race we need to fix Alan Cox
2012-06-22 15:42 ` [PATCH 04/12] gpio-sch: Fix resource leak Alan Cox
2012-06-27 2:25 ` Greg KH
2012-06-22 15:43 ` [PATCH 05/12] kobil_sct: Fix some bogus tty handling Alan Cox
2012-06-27 2:24 ` Greg KH
2012-06-22 15:43 ` [PATCH 06/12] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-06-27 2:30 ` Greg KH [this message]
2012-06-22 15:44 ` [PATCH 07/12] 8250: propogate the bugs field Alan Cox
2012-06-22 15:44 ` [PATCH 08/12] 8250: add support for ASIX devices with a FIFO bug Alan Cox
2012-06-22 15:44 ` [PATCH 09/12] commit 22126843cb3c2a782c2d52614486115f3e9db478 Alan Cox
2012-06-22 15:36 ` Greg KH
2012-06-22 17:04 ` Alan Cox
2012-08-01 0:51 ` Yinghai Lu
2012-06-22 15:46 ` [PATCH 10/12] tty: tidy up the RESET_TERMIOS case Alan Cox
2012-06-22 15:46 ` [PATCH 11/12] vt: fix the keyboard/led locking Alan Cox
2012-06-22 15:47 ` [PATCH 12/12] tty: move the handling of the tty release logic Alan Cox
2012-08-01 0:47 ` Yinghai Lu
2012-06-27 2:22 ` [PATCH 01/12] f81232: correct stubbed termios handler Greg KH
2012-06-27 2:22 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-06-27 11:21 Alan Cox
2012-06-27 11:22 ` [PATCH 06/12] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-06-27 22:39 ` Paul Gortmaker
2012-06-27 22:50 ` Alan Cox
2012-07-14 14:30 [PATCH 00/12] tty: take 3 - termios, locking and 8250 bugs Alan Cox
2012-07-14 14:33 ` [PATCH 06/12] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-07-16 20:09 ` Greg KH
2012-07-16 20:29 ` Alan Cox
2012-07-16 21:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627023024.GA13576@kroah.com \
--to=greg@kroah.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.