From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] remove -Werror from AM_INIT_AUTOMAKE
Date: Wed, 27 Jun 2012 07:20:09 +0300 [thread overview]
Message-ID: <20120627042009.GA2996@swordfish.datadirect.datadirectnet.com> (raw)
In-Reply-To: 1339972214-18301-1-git-send-email-moben@exherbo.org
[-- Attachment #1: Type: text/plain, Size: 1734 bytes --]
On (06/18/12 00:30), Benedikt Morbach wrote:
> While this is nice while developing, it may cause
> various problems with distributed tarballs.
>
> A new automake version could add a warning, causing errors for distributions
> and users, who might need to patch configure.ac and thus run autoreconf.
>
> For example, we hit an error where a third party package (gettext) uses
> functionality (AM_PROG_MKDIR_P) which is deprecated in newer automake versions(1.12.1),
> causing the powertop build to fail.
>
> Since the problem lies elsewhere, it is stupid to fail for this while building powertop
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4da4eea..ff4cdea 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3,7 +3,7 @@
>
> AC_PREREQ([2.68])
> AC_INIT([powertop], [2.0], [powertop(a)lists.01.org])
> -AM_INIT_AUTOMAKE([-Wall -Werror foreign ])
> +AM_INIT_AUTOMAKE([-Wall foreign ])
> AC_LANG([C++])
> AC_CONFIG_FILES([Makefile src/Makefile pevent/Makefile po/Makefile.in doc/Makefile])
> AC_CONFIG_SRCDIR([src/main.cpp])
>
Well,
This looks helpful.
I just hit that guy
automake-1.12: warnings are treated as errors
configure.ac:14: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and will soon be removed.
configure.ac:14: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:14: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
make: *** [Makefile.in] Error 1
according to lists, they are aware of this.
So, how about pushing that one?
Tested-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
-ss
next reply other threads:[~2012-06-27 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 4:20 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-27 18:19 [Powertop] [PATCH] remove -Werror from AM_INIT_AUTOMAKE Chris Ferron
2012-06-17 22:30 Benedikt Morbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627042009.GA2996@swordfish.datadirect.datadirectnet.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.