From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: [PATCH] kvm: don't clear level from irqfd Date: Wed, 27 Jun 2012 12:13:43 +0300 Message-ID: <20120627091343.GA17693@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alex Williamson , gleb@redhat.com To: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org irqfd sets and clears the level immediately. This used to be necessary for MSI interrupts but isn't anymore. Note! We never officially supported irqfd for level interrupts but it usually seemed to kind of work, and this change will break it. There are no known real users of that feature though - only old vfio prototypes. Removing this line will make it easier to add real support for level irqfds in the future. Signed-off-by: Michael S. Tsirkin --- virt/kvm/eventfd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index f59c1e8..4db6b01 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c @@ -68,7 +68,6 @@ irqfd_inject(struct work_struct *work) struct kvm *kvm = irqfd->kvm; kvm_set_irq(kvm, KVM_USERSPACE_IRQ_SOURCE_ID, irqfd->gsi, 1); - kvm_set_irq(kvm, KVM_USERSPACE_IRQ_SOURCE_ID, irqfd->gsi, 0); } /* -- MST