From: NeilBrown <neilb@suse.de>
To: NeilBrown <neilb@suse.de>
Cc: majianpeng <majianpeng@gmail.com>,
linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] md/raid5:Add "BlockedBadBlocks" flag when waitting rdev to be unlocked.
Date: Wed, 27 Jun 2012 13:55:07 +1000 [thread overview]
Message-ID: <20120627135507.115e32f7@notabene.brown> (raw)
In-Reply-To: <20120627134513.2a67fbb0@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Wed, 27 Jun 2012 13:45:13 +1000 NeilBrown <neilb@suse.de> wrote:
> Thanks for finding this. However I don't think your patch is quite correct.
> It would re-introduce a hang fixed by commit 43220aa0f22cd3ce5b3.
>
> I've applied the following instead.
>
....
> + else
> + /* Internal metadata will immediately
> + * be written by raid5d, so we don't
> + * need to wait here.
> + */
> + rdev_dec_pending(rdev, mddev);
> + }
... which is clearly wrong. That last line is now
rdev_dec_pending(s.blocked_rdev, conf->mddev);
NeilBrown
>
> if (s.handle_bad_blocks)
> for (i = disks; i--; ) {
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-06-27 3:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 3:13 [PATCH] md/raid5:Add "BlockedBadBlocks" flag when waitting rdev to be unlocked majianpeng
2012-06-27 3:45 ` NeilBrown
2012-06-27 3:55 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627135507.115e32f7@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=majianpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.