From: NeilBrown <neilb@suse.de>
To: majianpeng <majianpeng@gmail.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH 0/2] Modify read error handle for RAID-4,5,6.
Date: Wed, 27 Jun 2012 14:32:28 +1000 [thread overview]
Message-ID: <20120627143228.21ee4baa@notabene.brown> (raw)
In-Reply-To: <201205261052422815923@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]
On Sat, 26 May 2012 10:52:50 +0800 "majianpeng" <majianpeng@gmail.com> wrote:
> When RAID-4,5,6 degraded and met read-error, it will eject the rdev.And then
> the RAID will fail and lost data.Because the function of set-badsector,when
> this occur,it will set-badsector,not ejecting the rdev.
> When RAID-4,5,6 met read-error, it will re-write if RAID was not degrade.But if
> re-write error,it will eject the rdev and RAID will degrade and it will take too
> long time for recoverying.So I add judgement for controling how may re-write-error
> can eject the rdev.
>
> I do those for flexible controling the read-error for different situation.
>
Thanks.
>
> majianpeng (2):
> md/raid456: When readed error and raid was degraded,it try to
> set badsector, not ejecting the rdev.
I've applied this one. I also added 'set_bad = 1' in the case where
the re-write failed.
> md/raid456:Add interface for contorling eject rdev when re-write
> failed.
I haven't applied this. I'm not entirely sure what the point of counting
the errors was, but I don't think it is necessary.
Thanks,
NeilBrown
>
> drivers/md/md.c | 35 +++++++++++++++++++++++++++++++++++
> drivers/md/md.h | 2 ++
> drivers/md/raid5.c | 28 +++++++++++++++++++---------
> 3 files changed, 56 insertions(+), 9 deletions(-)
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-06-27 4:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 2:52 [PATCH 0/2] Modify read error handle for RAID-4,5,6 majianpeng
2012-06-27 4:32 ` NeilBrown [this message]
2012-06-27 6:03 ` majianpeng
2012-06-28 0:04 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627143228.21ee4baa@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=majianpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.