From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] i915: initialize CADL in opregion Date: Wed, 27 Jun 2012 17:03:02 +0200 Message-ID: <20120627150302.GE5326@phenom.ffwll.local> References: <1574631.uSlQXEJRId@al> <20120626140400.2cdb1f3f@jbarnes-desktop> <20120626210755.GB5072@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BE8BA0945 for ; Wed, 27 Jun 2012 08:03:07 -0700 (PDT) Received: by bkwj4 with SMTP id j4so1123886bkw.36 for ; Wed, 27 Jun 2012 08:03:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120626210755.GB5072@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Lekensteyn , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 26, 2012 at 11:07:55PM +0200, Daniel Vetter wrote: > On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote: > > On Tue, 26 Jun 2012 00:36:24 +0200 > > Lekensteyn wrote: > > > > > This is rather a hack to fix brightness hotkeys on a Clevo laptop. CADL is not > > > used anywhere in the driver code at the moment, but it could be used in BIOS as > > > is the case with the Clevo laptop. > > > > > > The Clevo B7130 requires the CADL field to contain at least the ID of > > > the LCD device. If this field is empty, the ACPI methods that are called > > > on pressing brightness / display switching hotkeys will not trigger a > > > notification. As a result, it appears as no hotkey has been pressed. > > > > Not ideal, but definitely better than nothing. > > > > Acked-by: Jesse Barnes > Queued for -next, thanks for the patch. Unfortunately this results in a neat black screen on my ivb zenbook. Until I've figured out what exactly's going on, I have to drop this from -next again. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48