From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/13 v2] sh: ecovec: switch MMC power control to regulators
Date: Thu, 28 Jun 2012 09:05:57 +0000 [thread overview]
Message-ID: <20120628090557.GA28162@linux-sh.org> (raw)
In-Reply-To: <1340751009-18663-2-git-send-email-g.liakhovetski@gmx.de>
On Wed, Jun 27, 2012 at 12:49:57AM +0200, Guennadi Liakhovetski wrote:
> Power on the CN11 and CN12 SD/MMC slots on ecovec is controlled by GPIOs,
> which makes it possible to use the fixed voltage regulator driver to switch
> card power on and off.
>
[snip]
> #if defined(CONFIG_MMC_SH_MMCIF) || defined(CONFIG_MMC_SH_MMCIF_MODULE)
> /* SH_MMCIF */
> -static void mmcif_set_pwr(struct platform_device *pdev, int state)
> -{
> - gpio_set_value(GPIO_PTB7, state);
> -}
> -
> static struct resource sh_mmcif_resources[] = {
> [0] = {
> .name = "SH_MMCIF",
> @@ -924,7 +1011,7 @@ static struct resource sh_mmcif_resources[] = {
> };
>
> static struct sh_mmcif_plat_data sh_mmcif_plat = {
> - .set_pwr = mmcif_set_pwr,
> + .set_pwr = cn12_set_pwr,
> .sup_pclk = 0, /* SH7724: Max Pclk/2 */
> .caps = MMC_CAP_4_BIT_DATA |
> MMC_CAP_8_BIT_DATA |
This doesn't match what is in the tree, so I have no idea what tree you
are working on. It fails to apply because of the down_pwr thing upstream
which doesn't exist in your patchset, and I'm certainly not going to
track it down.
Next time you send a patch series, make sure it actually applies to the
dependencies that you have written out, instead of some hypothetical tree
combination that needs to be reverse engineered.
The rest are applied. At least now you can go back and make those changes
to the patch while figuring out what tree you're working on.
prev parent reply other threads:[~2012-06-28 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 22:49 [PATCH 01/13 v2] sh: ecovec: switch MMC power control to regulators Guennadi Liakhovetski
2012-06-27 0:49 ` Paul Mundt
2012-06-28 9:05 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628090557.GA28162@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.