From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SkD2m-0005wp-AE for kexec@lists.infradead.org; Thu, 28 Jun 2012 11:37:52 +0000 Received: by pbbrq13 with SMTP id rq13so3182495pbb.36 for ; Thu, 28 Jun 2012 04:37:51 -0700 (PDT) Date: Thu, 28 Jun 2012 04:37:38 -0700 From: Greg KH Subject: Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs Message-ID: <20120628113738.GA5499@kroah.com> References: <4FEAC945.50700@cn.fujitsu.com> <4FEACA5E.4090009@cn.fujitsu.com> <20120627192236.GB1965@kroah.com> <4FEC29D6.5020109@cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4FEC29D6.5020109@cn.fujitsu.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Yanfei Zhang Cc: dzickus@redhat.com, luto@mit.edu, kvm@vger.kernel.org, Joerg Roedel , mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, Avi Kivity , ebiederm@xmission.com T24gVGh1LCBKdW4gMjgsIDIwMTIgYXQgMDU6NTQ6MzBQTSArMDgwMCwgWWFuZmVpIFpoYW5nIHdy b3RlOgo+IOS6jiAyMDEy5bm0MDbmnIgyOOaXpSAwMzoyMiwgR3JlZyBLSCDlhpnpgZM6Cj4gPiBP biBXZWQsIEp1biAyNywgMjAxMiBhdCAwNDo1NDo1NFBNICswODAwLCBZYW5mZWkgWmhhbmcgd3Jv dGU6Cj4gPj4gVGhpcyBwYXRjaCBleHBvcnQgb2Zmc2V0cyBvZiBmaWVsZHMgdmlhIC9zeXMvZGV2 aWNlcy9jcHUvdm1jcy8uCj4gPj4gSW5kaXZpZHVhbCBvZmZzZXRzIGFyZSBjb250YWluZWQgaW4g c3ViZmlsZXMgbmFtZWQgYnkgdGhlIGZpbGVkJ3MKPiA+PiBlbmNvZGluZywgZS5nLjogL3N5cy9k ZXZpY2VzL2NwdS92bWNzLzA4MDAKPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IHpoYW5neWFuZmVp IDx6aGFuZ3lhbmZlaUBjbi5mdWppdHN1LmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9iYXNl L2NvcmUuYyB8ICAgMTMgKysrKysrKysrKysrKwo+ID4+ICAxIGZpbGVzIGNoYW5nZWQsIDEzIGlu c2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9iYXNlL2NvcmUuYyBiL2RyaXZlcnMvYmFzZS9jb3JlLmMKPiA+PiBpbmRleCAzNDZiZThiLi5k ZDA1ZWU3IDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvYmFzZS9jb3JlLmMKPiA+PiArKysgYi9k cml2ZXJzL2Jhc2UvY29yZS5jCj4gPj4gQEAgLTI2LDYgKzI2LDcgQEAKPiA+PiAgI2luY2x1ZGUg PGxpbnV4L2FzeW5jLmg+Cj4gPj4gICNpbmNsdWRlIDxsaW51eC9wbV9ydW50aW1lLmg+Cj4gPj4g ICNpbmNsdWRlIDxsaW51eC9uZXRkZXZpY2UuaD4KPiA+PiArI2luY2x1ZGUgPGFzbS92bWNzaW5m by5oPgo+ID4gCj4gPiBEaWQgeW91IGp1c3QgYnJlYWsgdGhlIGJ1aWxkIG9uIGFsbCBvdGhlciBh cmNoZXM/ICBOb3QgbmljZS4KPiA+IAo+ID4+IEBAIC0xMDM4LDYgKzEwMzksMTEgQEAgaW50IGRl dmljZV9hZGQoc3RydWN0IGRldmljZSAqZGV2KQo+ID4+ICAJZXJyb3IgPSBkcG1fc3lzZnNfYWRk KGRldik7Cj4gPj4gIAlpZiAoZXJyb3IpCj4gPj4gIAkJZ290byBEUE1FcnJvcjsKPiA+PiArI2lm IGRlZmluZWQoQ09ORklHX0tWTV9JTlRFTCkgfHwgZGVmaW5lZChDT05GSUdfS1ZNX0lOVEVMX01P RFVMRSkKPiA+PiArCWVycm9yID0gdm1jc19zeXNmc19hZGQoZGV2KTsKPiA+PiArCWlmIChlcnJv cikKPiA+PiArCQlnb3RvIFZNQ1NFcnJvcjsKPiA+PiArI2VuZGlmCj4gPiAKPiA+IE9oIG15IG5v LCB0aGF0J3Mgbm8gd2F5IHRvIGV2ZXIgZG8gdGhpcywgeW91IGtub3cgYmV0dGVyIHRoYW4gdGhh dCwKPiA+IHBsZWFzZSBmaXguCj4gPiAKPiA+IGdyZWcgay1oCj4gPiAKPiAKPiBTb3JyeSBmb3Ig bXkgdGhvdWdodGxlc3MsIEhlcmUgaXMgdGhlIG5ldyBwYXRjaC4KPiAKPiAtLS0KPiAgZHJpdmVy cy9iYXNlL2NvcmUuYyB8ICAgMTMgKysrKysrKysrKysrKwo+ICAxIGZpbGVzIGNoYW5nZWQsIDEz IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv YmFzZS9jb3JlLmMgYi9kcml2ZXJzL2Jhc2UvY29yZS5jCj4gaW5kZXggMzQ2YmU4Yi4uN2I1MjY2 YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2Jhc2UvY29yZS5jCj4gKysrIGIvZHJpdmVycy9iYXNl L2NvcmUuYwo+IEBAIC0zMCw2ICszMCwxMyBAQAo+ICAjaW5jbHVkZSAiYmFzZS5oIgo+ICAjaW5j bHVkZSAicG93ZXIvcG93ZXIuaCIKPiAgCj4gKyNpZiBkZWZpbmVkKENPTkZJR19LVk1fSU5URUwp IHx8IGRlZmluZWQoQ09ORklHX0tWTV9JTlRFTF9NT0RVTEUpCj4gKyNpbmNsdWRlIDxhc20vdm1j c2luZm8uaD4KPiArI2Vsc2UKPiArc3RhdGljIGlubGluZSBpbnQgdm1jc19zeXNmc19hZGQoc3Ry dWN0IGRldmljZSAqZGV2KSB7IHJldHVybiAwOyB9Cj4gK3N0YXRpYyBpbmxpbmUgdm9pZCB2bWNz X3N5c2ZzX3JlbW92ZShzdHJ1Y3QgZGV2aWNlICpkZXYpIHsgfQo+ICsjZW5kaWYKCntzaWdofSAg Tm8sIGFnYWluLCB5b3Uga25vdyBiZXR0ZXIsIGRvbid0IGRvIHRoaXMuCgpncmVnIGstaAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2V4ZWMgbWFpbGlu ZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs Date: Thu, 28 Jun 2012 04:37:38 -0700 Message-ID: <20120628113738.GA5499@kroah.com> References: <4FEAC945.50700@cn.fujitsu.com> <4FEACA5E.4090009@cn.fujitsu.com> <20120627192236.GB1965@kroah.com> <4FEC29D6.5020109@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Avi Kivity , mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, Joerg Roedel , dzickus@redhat.com, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org To: Yanfei Zhang Return-path: Content-Disposition: inline In-Reply-To: <4FEC29D6.5020109@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Jun 28, 2012 at 05:54:30PM +0800, Yanfei Zhang wrote: > =E4=BA=8E 2012=E5=B9=B406=E6=9C=8828=E6=97=A5 03:22, Greg KH =E5=86=99= =E9=81=93: > > On Wed, Jun 27, 2012 at 04:54:54PM +0800, Yanfei Zhang wrote: > >> This patch export offsets of fields via /sys/devices/cpu/vmcs/. > >> Individual offsets are contained in subfiles named by the filed's > >> encoding, e.g.: /sys/devices/cpu/vmcs/0800 > >> > >> Signed-off-by: zhangyanfei > >> --- > >> drivers/base/core.c | 13 +++++++++++++ > >> 1 files changed, 13 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/base/core.c b/drivers/base/core.c > >> index 346be8b..dd05ee7 100644 > >> --- a/drivers/base/core.c > >> +++ b/drivers/base/core.c > >> @@ -26,6 +26,7 @@ > >> #include > >> #include > >> #include > >> +#include > >=20 > > Did you just break the build on all other arches? Not nice. > >=20 > >> @@ -1038,6 +1039,11 @@ int device_add(struct device *dev) > >> error =3D dpm_sysfs_add(dev); > >> if (error) > >> goto DPMError; > >> +#if defined(CONFIG_KVM_INTEL) || defined(CONFIG_KVM_INTEL_MODULE) > >> + error =3D vmcs_sysfs_add(dev); > >> + if (error) > >> + goto VMCSError; > >> +#endif > >=20 > > Oh my no, that's no way to ever do this, you know better than that, > > please fix. > >=20 > > greg k-h > >=20 >=20 > Sorry for my thoughtless, Here is the new patch. >=20 > --- > drivers/base/core.c | 13 +++++++++++++ > 1 files changed, 13 insertions(+), 0 deletions(-) >=20 > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 346be8b..7b5266a 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -30,6 +30,13 @@ > #include "base.h" > #include "power/power.h" > =20 > +#if defined(CONFIG_KVM_INTEL) || defined(CONFIG_KVM_INTEL_MODULE) > +#include > +#else > +static inline int vmcs_sysfs_add(struct device *dev) { return 0; } > +static inline void vmcs_sysfs_remove(struct device *dev) { } > +#endif {sigh} No, again, you know better, don't do this. greg k-h