From: Mike Frysinger <vapier@gentoo.org>
To: kerolasa@gmail.com
Cc: "util-linux" <util-linux@vger.kernel.org>
Subject: Re: [pull] /run directory and swapon
Date: Thu, 28 Jun 2012 23:38:40 -0400 [thread overview]
Message-ID: <201206282338.41501.vapier@gentoo.org> (raw)
In-Reply-To: <CAG27Bk3xh7nAhvktOR45drKcKBgaCTtFqduOyvWz5arTGegCBA@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 729 bytes --]
On Wednesday 27 June 2012 17:33:25 Sami Kerola wrote:
> --- a/configure.ac
> +++ b/configure.ac
>
> +case $prefix:$localstatedir in
> + NONE:'${prefix}/var')
> + localstatedir=/run
> + AC_MSG_NOTICE([ --localstatedir defaults to /run])
i'd trim the leading whitespace in the message
> + ;;
> + *:'${prefix}/var')
> + localstatedir=${prefix}/run
> + ;;
> + NONE:*)
> + ;;
> + *:*)
> + localstatedir=${prefix}/${localstatedir}
> + ;;
> +esac
is this last case just so you can AC_DEFINE the value below ? in general,
this is fragile. defines should be expanded at make time rather than configure.
CPPFLAGS="$CPPFLAGS -D_PATH_LOCALSTATEDIR=\"\${localstatedir}\""
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-29 3:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 21:33 [pull] /run directory and swapon Sami Kerola
2012-06-28 5:45 ` Bernhard Voelker
2012-06-28 6:21 ` Bernhard Voelker
2012-06-28 8:06 ` Sami Kerola
2012-07-10 9:56 ` Karel Zak
2012-06-29 3:38 ` Mike Frysinger [this message]
2012-06-30 20:59 ` Sami Kerola
2012-07-10 10:08 ` Karel Zak
2012-07-10 11:10 ` Karel Zak
2012-07-10 11:56 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206282338.41501.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.