All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
	linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] regulator: fixed: support deferred probe for DT GPIOs
Date: Fri, 29 Jun 2012 02:25:08 +0100	[thread overview]
Message-ID: <20120629012507.GL28922@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1340922692-24092-1-git-send-email-swarren@wwwdotorg.org>

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

On Thu, Jun 28, 2012 at 04:31:32PM -0600, Stephen Warren wrote:

>  static struct fixed_voltage_config *
> -of_get_fixed_voltage_config(struct device *dev)
> +of_get_fixed_voltage_config(struct device *dev, bool *defer_probe)

This is pretty contorted, we should just be able to pass the return
value back more directly and of course ideally gpiolib would be doing
the -EPROBE_DEFER for us anyway (I did send a patch for this, Grant
didn't apply it due to a mostly unrelated issue in the current probe
deferral implementation).  Or just defer if we don't get a config passed
back or something.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-06-29  1:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 22:31 [PATCH] regulator: fixed: support deferred probe for DT GPIOs Stephen Warren
2012-06-29  1:25 ` Mark Brown [this message]
2012-06-29 15:30   ` Stephen Warren
2012-06-30 11:48     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120629012507.GL28922@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.