From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gh0-f177.google.com ([209.85.160.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SkRai-0004SS-CR for kexec@lists.infradead.org; Fri, 29 Jun 2012 03:09:52 +0000 Received: by ghbf11 with SMTP id f11so2570270ghb.36 for ; Thu, 28 Jun 2012 20:09:50 -0700 (PDT) Date: Thu, 28 Jun 2012 22:58:48 -0400 From: Greg KH Subject: Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs Message-ID: <20120629025848.GC8074@kroah.com> References: <4FEAC945.50700@cn.fujitsu.com> <4FEACA5E.4090009@cn.fujitsu.com> <20120627192236.GB1965@kroah.com> <4FEC29D6.5020109@cn.fujitsu.com> <20120628113738.GA5499@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120628113738.GA5499@kroah.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Yanfei Zhang Cc: dzickus@redhat.com, luto@mit.edu, kvm@vger.kernel.org, Joerg Roedel , mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, Avi Kivity , ebiederm@xmission.com T24gVGh1LCBKdW4gMjgsIDIwMTIgYXQgMDQ6Mzc6MzhBTSAtMDcwMCwgR3JlZyBLSCB3cm90ZToK PiBPbiBUaHUsIEp1biAyOCwgMjAxMiBhdCAwNTo1NDozMFBNICswODAwLCBZYW5mZWkgWmhhbmcg d3JvdGU6Cj4gPiDkuo4gMjAxMuW5tDA25pyIMjjml6UgMDM6MjIsIEdyZWcgS0gg5YaZ6YGTOgo+ ID4gPiBPbiBXZWQsIEp1biAyNywgMjAxMiBhdCAwNDo1NDo1NFBNICswODAwLCBZYW5mZWkgWmhh bmcgd3JvdGU6Cj4gPiA+PiBUaGlzIHBhdGNoIGV4cG9ydCBvZmZzZXRzIG9mIGZpZWxkcyB2aWEg L3N5cy9kZXZpY2VzL2NwdS92bWNzLy4KPiA+ID4+IEluZGl2aWR1YWwgb2Zmc2V0cyBhcmUgY29u dGFpbmVkIGluIHN1YmZpbGVzIG5hbWVkIGJ5IHRoZSBmaWxlZCdzCj4gPiA+PiBlbmNvZGluZywg ZS5nLjogL3N5cy9kZXZpY2VzL2NwdS92bWNzLzA4MDAKPiA+ID4+Cj4gPiA+PiBTaWduZWQtb2Zm LWJ5OiB6aGFuZ3lhbmZlaSA8emhhbmd5YW5mZWlAY24uZnVqaXRzdS5jb20+Cj4gPiA+PiAtLS0K PiA+ID4+ICBkcml2ZXJzL2Jhc2UvY29yZS5jIHwgICAxMyArKysrKysrKysrKysrCj4gPiA+PiAg MSBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQo+ID4gPj4K PiA+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Jhc2UvY29yZS5jIGIvZHJpdmVycy9iYXNlL2Nv cmUuYwo+ID4gPj4gaW5kZXggMzQ2YmU4Yi4uZGQwNWVlNyAxMDA2NDQKPiA+ID4+IC0tLSBhL2Ry aXZlcnMvYmFzZS9jb3JlLmMKPiA+ID4+ICsrKyBiL2RyaXZlcnMvYmFzZS9jb3JlLmMKPiA+ID4+ IEBAIC0yNiw2ICsyNiw3IEBACj4gPiA+PiAgI2luY2x1ZGUgPGxpbnV4L2FzeW5jLmg+Cj4gPiA+ PiAgI2luY2x1ZGUgPGxpbnV4L3BtX3J1bnRpbWUuaD4KPiA+ID4+ICAjaW5jbHVkZSA8bGludXgv bmV0ZGV2aWNlLmg+Cj4gPiA+PiArI2luY2x1ZGUgPGFzbS92bWNzaW5mby5oPgo+ID4gPiAKPiA+ ID4gRGlkIHlvdSBqdXN0IGJyZWFrIHRoZSBidWlsZCBvbiBhbGwgb3RoZXIgYXJjaGVzPyAgTm90 IG5pY2UuCj4gPiA+IAo+ID4gPj4gQEAgLTEwMzgsNiArMTAzOSwxMSBAQCBpbnQgZGV2aWNlX2Fk ZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiA+PiAgCWVycm9yID0gZHBtX3N5c2ZzX2FkZChkZXYp Owo+ID4gPj4gIAlpZiAoZXJyb3IpCj4gPiA+PiAgCQlnb3RvIERQTUVycm9yOwo+ID4gPj4gKyNp ZiBkZWZpbmVkKENPTkZJR19LVk1fSU5URUwpIHx8IGRlZmluZWQoQ09ORklHX0tWTV9JTlRFTF9N T0RVTEUpCj4gPiA+PiArCWVycm9yID0gdm1jc19zeXNmc19hZGQoZGV2KTsKPiA+ID4+ICsJaWYg KGVycm9yKQo+ID4gPj4gKwkJZ290byBWTUNTRXJyb3I7Cj4gPiA+PiArI2VuZGlmCj4gPiA+IAo+ ID4gPiBPaCBteSBubywgdGhhdCdzIG5vIHdheSB0byBldmVyIGRvIHRoaXMsIHlvdSBrbm93IGJl dHRlciB0aGFuIHRoYXQsCj4gPiA+IHBsZWFzZSBmaXguCj4gPiA+IAo+ID4gPiBncmVnIGstaAo+ ID4gPiAKPiA+IAo+ID4gU29ycnkgZm9yIG15IHRob3VnaHRsZXNzLCBIZXJlIGlzIHRoZSBuZXcg cGF0Y2guCj4gPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvYmFzZS9jb3JlLmMgfCAgIDEzICsrKysr KysrKysrKysKPiA+ICAxIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDAgZGVsZXRp b25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Jhc2UvY29yZS5jIGIvZHJpdmVy cy9iYXNlL2NvcmUuYwo+ID4gaW5kZXggMzQ2YmU4Yi4uN2I1MjY2YSAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvYmFzZS9jb3JlLmMKPiA+ICsrKyBiL2RyaXZlcnMvYmFzZS9jb3JlLmMKPiA+IEBA IC0zMCw2ICszMCwxMyBAQAo+ID4gICNpbmNsdWRlICJiYXNlLmgiCj4gPiAgI2luY2x1ZGUgInBv d2VyL3Bvd2VyLmgiCj4gPiAgCj4gPiArI2lmIGRlZmluZWQoQ09ORklHX0tWTV9JTlRFTCkgfHwg ZGVmaW5lZChDT05GSUdfS1ZNX0lOVEVMX01PRFVMRSkKPiA+ICsjaW5jbHVkZSA8YXNtL3ZtY3Np bmZvLmg+Cj4gPiArI2Vsc2UKPiA+ICtzdGF0aWMgaW5saW5lIGludCB2bWNzX3N5c2ZzX2FkZChz dHJ1Y3QgZGV2aWNlICpkZXYpIHsgcmV0dXJuIDA7IH0KPiA+ICtzdGF0aWMgaW5saW5lIHZvaWQg dm1jc19zeXNmc19yZW1vdmUoc3RydWN0IGRldmljZSAqZGV2KSB7IH0KPiA+ICsjZW5kaWYKPiAK PiB7c2lnaH0gIE5vLCBhZ2FpbiwgeW91IGtub3cgYmV0dGVyLCBkb24ndCBkbyB0aGlzLgoKT2ss IGFzIG90aGVycyBoYXZlIHJpZ2h0bHkgcG9pbnRlZCBvdXQsIHRoaXMgd2Fzbid0IHRoZSBtb3N0 IGhlbHBmdWwKcmV2aWV3IGNvbW1lbnQsIHNvcnJ5IGFib3V0IHRoYXQuCgpJbiBMaW51eCwgd2Ug ZG9uJ3QgcHV0IGlmZGVmcyBpbiAuYyBmaWxlcywgd2UgcHV0IHRoZW0gaW4gLmggZmlsZXMuICBT ZWUKbWFueSBleGFtcGxlcyBvZiB0aGlzIGFsbCBvdmVyIHRoZSBwbGFjZS4gIFRoYXQncyBteSBt YWluIGNvbXBsYWludHMgdGhlCnBhc3QgdHdvIHRpbWVzIG9mIHRoaXMgcGF0Y2guCgpCdXQsIGZv ciB0aGlzLCBJIHdvdWxkIHF1ZXN0aW9uIHdoeSB5b3UgZXZlbiB3YW50IC8gbmVlZCB0byBkbyB0 aGlzIGluCnRoZSBkcml2ZXJzL2Jhc2UvY29yZS8gZmlsZSBpbiB0aGUgZmlyc3QgcGxhY2UuICBT aG91bGRuJ3QgaXQgYmUgaW4gc29tZQphcmNoIG9yIGNwdSBzcGVjaWZpYyBmaWxlIGluc3RlYWQg dGhhdCBhbHJlYWR5IGhhbmRsZXMgdGhlIGNwdSBmaWxlcz8KCnRoYW5rcywKCmdyZWcgay1oCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWls aW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs Date: Thu, 28 Jun 2012 22:58:48 -0400 Message-ID: <20120629025848.GC8074@kroah.com> References: <4FEAC945.50700@cn.fujitsu.com> <4FEACA5E.4090009@cn.fujitsu.com> <20120627192236.GB1965@kroah.com> <4FEC29D6.5020109@cn.fujitsu.com> <20120628113738.GA5499@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, luto-3s7WtUTddSA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joerg Roedel , mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, ludwig.nussel-l3A5Bk7waGM@public.gmane.org, Avi Kivity , ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org To: Yanfei Zhang Return-path: Content-Disposition: inline In-Reply-To: <20120628113738.GA5499-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org T24gVGh1LCBKdW4gMjgsIDIwMTIgYXQgMDQ6Mzc6MzhBTSAtMDcwMCwgR3JlZyBLSCB3cm90ZToK PiBPbiBUaHUsIEp1biAyOCwgMjAxMiBhdCAwNTo1NDozMFBNICswODAwLCBZYW5mZWkgWmhhbmcg d3JvdGU6Cj4gPiDkuo4gMjAxMuW5tDA25pyIMjjml6UgMDM6MjIsIEdyZWcgS0gg5YaZ6YGTOgo+ ID4gPiBPbiBXZWQsIEp1biAyNywgMjAxMiBhdCAwNDo1NDo1NFBNICswODAwLCBZYW5mZWkgWmhh bmcgd3JvdGU6Cj4gPiA+PiBUaGlzIHBhdGNoIGV4cG9ydCBvZmZzZXRzIG9mIGZpZWxkcyB2aWEg L3N5cy9kZXZpY2VzL2NwdS92bWNzLy4KPiA+ID4+IEluZGl2aWR1YWwgb2Zmc2V0cyBhcmUgY29u dGFpbmVkIGluIHN1YmZpbGVzIG5hbWVkIGJ5IHRoZSBmaWxlZCdzCj4gPiA+PiBlbmNvZGluZywg ZS5nLjogL3N5cy9kZXZpY2VzL2NwdS92bWNzLzA4MDAKPiA+ID4+Cj4gPiA+PiBTaWduZWQtb2Zm LWJ5OiB6aGFuZ3lhbmZlaSA8emhhbmd5YW5mZWlAY24uZnVqaXRzdS5jb20+Cj4gPiA+PiAtLS0K PiA+ID4+ICBkcml2ZXJzL2Jhc2UvY29yZS5jIHwgICAxMyArKysrKysrKysrKysrCj4gPiA+PiAg MSBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQo+ID4gPj4K PiA+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Jhc2UvY29yZS5jIGIvZHJpdmVycy9iYXNlL2Nv cmUuYwo+ID4gPj4gaW5kZXggMzQ2YmU4Yi4uZGQwNWVlNyAxMDA2NDQKPiA+ID4+IC0tLSBhL2Ry aXZlcnMvYmFzZS9jb3JlLmMKPiA+ID4+ICsrKyBiL2RyaXZlcnMvYmFzZS9jb3JlLmMKPiA+ID4+ IEBAIC0yNiw2ICsyNiw3IEBACj4gPiA+PiAgI2luY2x1ZGUgPGxpbnV4L2FzeW5jLmg+Cj4gPiA+ PiAgI2luY2x1ZGUgPGxpbnV4L3BtX3J1bnRpbWUuaD4KPiA+ID4+ICAjaW5jbHVkZSA8bGludXgv bmV0ZGV2aWNlLmg+Cj4gPiA+PiArI2luY2x1ZGUgPGFzbS92bWNzaW5mby5oPgo+ID4gPiAKPiA+ ID4gRGlkIHlvdSBqdXN0IGJyZWFrIHRoZSBidWlsZCBvbiBhbGwgb3RoZXIgYXJjaGVzPyAgTm90 IG5pY2UuCj4gPiA+IAo+ID4gPj4gQEAgLTEwMzgsNiArMTAzOSwxMSBAQCBpbnQgZGV2aWNlX2Fk ZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiA+PiAgCWVycm9yID0gZHBtX3N5c2ZzX2FkZChkZXYp Owo+ID4gPj4gIAlpZiAoZXJyb3IpCj4gPiA+PiAgCQlnb3RvIERQTUVycm9yOwo+ID4gPj4gKyNp ZiBkZWZpbmVkKENPTkZJR19LVk1fSU5URUwpIHx8IGRlZmluZWQoQ09ORklHX0tWTV9JTlRFTF9N T0RVTEUpCj4gPiA+PiArCWVycm9yID0gdm1jc19zeXNmc19hZGQoZGV2KTsKPiA+ID4+ICsJaWYg KGVycm9yKQo+ID4gPj4gKwkJZ290byBWTUNTRXJyb3I7Cj4gPiA+PiArI2VuZGlmCj4gPiA+IAo+ ID4gPiBPaCBteSBubywgdGhhdCdzIG5vIHdheSB0byBldmVyIGRvIHRoaXMsIHlvdSBrbm93IGJl dHRlciB0aGFuIHRoYXQsCj4gPiA+IHBsZWFzZSBmaXguCj4gPiA+IAo+ID4gPiBncmVnIGstaAo+ ID4gPiAKPiA+IAo+ID4gU29ycnkgZm9yIG15IHRob3VnaHRsZXNzLCBIZXJlIGlzIHRoZSBuZXcg cGF0Y2guCj4gPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvYmFzZS9jb3JlLmMgfCAgIDEzICsrKysr KysrKysrKysKPiA+ICAxIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDAgZGVsZXRp b25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Jhc2UvY29yZS5jIGIvZHJpdmVy cy9iYXNlL2NvcmUuYwo+ID4gaW5kZXggMzQ2YmU4Yi4uN2I1MjY2YSAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvYmFzZS9jb3JlLmMKPiA+ICsrKyBiL2RyaXZlcnMvYmFzZS9jb3JlLmMKPiA+IEBA IC0zMCw2ICszMCwxMyBAQAo+ID4gICNpbmNsdWRlICJiYXNlLmgiCj4gPiAgI2luY2x1ZGUgInBv d2VyL3Bvd2VyLmgiCj4gPiAgCj4gPiArI2lmIGRlZmluZWQoQ09ORklHX0tWTV9JTlRFTCkgfHwg ZGVmaW5lZChDT05GSUdfS1ZNX0lOVEVMX01PRFVMRSkKPiA+ICsjaW5jbHVkZSA8YXNtL3ZtY3Np bmZvLmg+Cj4gPiArI2Vsc2UKPiA+ICtzdGF0aWMgaW5saW5lIGludCB2bWNzX3N5c2ZzX2FkZChz dHJ1Y3QgZGV2aWNlICpkZXYpIHsgcmV0dXJuIDA7IH0KPiA+ICtzdGF0aWMgaW5saW5lIHZvaWQg dm1jc19zeXNmc19yZW1vdmUoc3RydWN0IGRldmljZSAqZGV2KSB7IH0KPiA+ICsjZW5kaWYKPiAK PiB7c2lnaH0gIE5vLCBhZ2FpbiwgeW91IGtub3cgYmV0dGVyLCBkb24ndCBkbyB0aGlzLgoKT2ss IGFzIG90aGVycyBoYXZlIHJpZ2h0bHkgcG9pbnRlZCBvdXQsIHRoaXMgd2Fzbid0IHRoZSBtb3N0 IGhlbHBmdWwKcmV2aWV3IGNvbW1lbnQsIHNvcnJ5IGFib3V0IHRoYXQuCgpJbiBMaW51eCwgd2Ug ZG9uJ3QgcHV0IGlmZGVmcyBpbiAuYyBmaWxlcywgd2UgcHV0IHRoZW0gaW4gLmggZmlsZXMuICBT ZWUKbWFueSBleGFtcGxlcyBvZiB0aGlzIGFsbCBvdmVyIHRoZSBwbGFjZS4gIFRoYXQncyBteSBt YWluIGNvbXBsYWludHMgdGhlCnBhc3QgdHdvIHRpbWVzIG9mIHRoaXMgcGF0Y2guCgpCdXQsIGZv ciB0aGlzLCBJIHdvdWxkIHF1ZXN0aW9uIHdoeSB5b3UgZXZlbiB3YW50IC8gbmVlZCB0byBkbyB0 aGlzIGluCnRoZSBkcml2ZXJzL2Jhc2UvY29yZS8gZmlsZSBpbiB0aGUgZmlyc3QgcGxhY2UuICBT aG91bGRuJ3QgaXQgYmUgaW4gc29tZQphcmNoIG9yIGNwdSBzcGVjaWZpYyBmaWxlIGluc3RlYWQg dGhhdCBhbHJlYWR5IGhhbmRsZXMgdGhlIGNwdSBmaWxlcz8KCnRoYW5rcywKCmdyZWcgay1oCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWls aW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754779Ab2F2DJx (ORCPT ); Thu, 28 Jun 2012 23:09:53 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:41397 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752872Ab2F2DJv (ORCPT ); Thu, 28 Jun 2012 23:09:51 -0400 Date: Thu, 28 Jun 2012 22:58:48 -0400 From: Greg KH To: Yanfei Zhang Cc: Avi Kivity , mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, Joerg Roedel , dzickus@redhat.com, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs Message-ID: <20120629025848.GC8074@kroah.com> References: <4FEAC945.50700@cn.fujitsu.com> <4FEACA5E.4090009@cn.fujitsu.com> <20120627192236.GB1965@kroah.com> <4FEC29D6.5020109@cn.fujitsu.com> <20120628113738.GA5499@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120628113738.GA5499@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 28, 2012 at 04:37:38AM -0700, Greg KH wrote: > On Thu, Jun 28, 2012 at 05:54:30PM +0800, Yanfei Zhang wrote: > > 于 2012年06月28日 03:22, Greg KH 写道: > > > On Wed, Jun 27, 2012 at 04:54:54PM +0800, Yanfei Zhang wrote: > > >> This patch export offsets of fields via /sys/devices/cpu/vmcs/. > > >> Individual offsets are contained in subfiles named by the filed's > > >> encoding, e.g.: /sys/devices/cpu/vmcs/0800 > > >> > > >> Signed-off-by: zhangyanfei > > >> --- > > >> drivers/base/core.c | 13 +++++++++++++ > > >> 1 files changed, 13 insertions(+), 0 deletions(-) > > >> > > >> diff --git a/drivers/base/core.c b/drivers/base/core.c > > >> index 346be8b..dd05ee7 100644 > > >> --- a/drivers/base/core.c > > >> +++ b/drivers/base/core.c > > >> @@ -26,6 +26,7 @@ > > >> #include > > >> #include > > >> #include > > >> +#include > > > > > > Did you just break the build on all other arches? Not nice. > > > > > >> @@ -1038,6 +1039,11 @@ int device_add(struct device *dev) > > >> error = dpm_sysfs_add(dev); > > >> if (error) > > >> goto DPMError; > > >> +#if defined(CONFIG_KVM_INTEL) || defined(CONFIG_KVM_INTEL_MODULE) > > >> + error = vmcs_sysfs_add(dev); > > >> + if (error) > > >> + goto VMCSError; > > >> +#endif > > > > > > Oh my no, that's no way to ever do this, you know better than that, > > > please fix. > > > > > > greg k-h > > > > > > > Sorry for my thoughtless, Here is the new patch. > > > > --- > > drivers/base/core.c | 13 +++++++++++++ > > 1 files changed, 13 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/base/core.c b/drivers/base/core.c > > index 346be8b..7b5266a 100644 > > --- a/drivers/base/core.c > > +++ b/drivers/base/core.c > > @@ -30,6 +30,13 @@ > > #include "base.h" > > #include "power/power.h" > > > > +#if defined(CONFIG_KVM_INTEL) || defined(CONFIG_KVM_INTEL_MODULE) > > +#include > > +#else > > +static inline int vmcs_sysfs_add(struct device *dev) { return 0; } > > +static inline void vmcs_sysfs_remove(struct device *dev) { } > > +#endif > > {sigh} No, again, you know better, don't do this. Ok, as others have rightly pointed out, this wasn't the most helpful review comment, sorry about that. In Linux, we don't put ifdefs in .c files, we put them in .h files. See many examples of this all over the place. That's my main complaints the past two times of this patch. But, for this, I would question why you even want / need to do this in the drivers/base/core/ file in the first place. Shouldn't it be in some arch or cpu specific file instead that already handles the cpu files? thanks, greg k-h