Re: [PATCH] drm/i915: fix up ilk rc6 disabling confusion

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Jun 29, 2012 at 08:36:14PM -0300, Eugeni Dodonov wrote:
> On 06/29/2012 06:32 PM, Daniel Vetter wrote:
> > @@ -7270,6 +7270,8 @@ void intel_modeset_cleanup(struct drm_device *dev)
> >  
> >  	intel_disable_gt_powersave(dev);
> >  
> > +	ironlake_teardown_rc6(dev);
> > +
> 
> Couldn't we pass a true/false parameter to the
> intel_disable_gt_powersave for tearing down ironlake RC6 directly instead?
> 
> Something like
> intel_disable_gt_powersave(struct drm_device *dev, bool teardown_context);
> 
> maybe?

Well, I want to separate setup/teardown code that we only run at driver
load and unload time from hw enable/disable code that we also need to run
around suspend/resume. So no, I explicitly don't want such convoluted
stuff any more. Similarly for code that checks at resume time whether
things are set up already, e.g. the ringbuffer stuff or contexts.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48