diff for duplicates of <20120630121748.GD22767@elgon.mountain> diff --git a/a/1.txt b/N1/1.txt index 3937628..b01eea5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,5 +1,5 @@ In 555d3d5d "SCTP: Fix chunk acceptance when no authenticated chunks -were listed.", we added a check for if (param->param_hdr.length = 0). +were listed.", we added a check for if (param->param_hdr.length == 0). Shouldn't that check be a check for if (param->param_hdr.length < sizeos(sizeof(sctp_paramhdr_t)))? Otherwise, when we do the substraction on the next line we would unintentionally @@ -11,7 +11,7 @@ net/sctp/auth.c 770 /* Check if we can add this chunk to the array */ 771 param_len = ntohs(p->param_hdr.length); 772 nchunks = param_len - sizeof(sctp_paramhdr_t); - 773 if (nchunks = SCTP_NUM_CHUNK_TYPES) + 773 if (nchunks == SCTP_NUM_CHUNK_TYPES) 774 return -EINVAL; 775 776 p->chunks[nchunks] = chunk_id; diff --git a/a/content_digest b/N1/content_digest index bef6530..443d906 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,13 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0possible integer underflow in __sctp_auth_cid()\0" - "Date\0Sat, 30 Jun 2012 12:17:48 +0000\0" + "Date\0Sat, 30 Jun 2012 15:17:48 +0300\0" "To\0Vlad Yasevich <vyasevich@gmail.com>\0" "Cc\0linux-sctp@vger.kernel.org" " netdev@vger.kernel.org\0" "\00:1\0" "b\0" "In 555d3d5d \"SCTP: Fix chunk acceptance when no authenticated chunks\n" - "were listed.\", we added a check for if (param->param_hdr.length = 0).\n" + "were listed.\", we added a check for if (param->param_hdr.length == 0).\n" "Shouldn't that check be a check for if\n" "(param->param_hdr.length < sizeos(sizeof(sctp_paramhdr_t)))? Otherwise,\n" "when we do the substraction on the next line we would unintentionally\n" @@ -19,7 +19,7 @@ " 770 /* Check if we can add this chunk to the array */\n" " 771 param_len = ntohs(p->param_hdr.length);\n" " 772 nchunks = param_len - sizeof(sctp_paramhdr_t);\n" - " 773 if (nchunks = SCTP_NUM_CHUNK_TYPES)\n" + " 773 if (nchunks == SCTP_NUM_CHUNK_TYPES)\n" " 774 return -EINVAL;\n" " 775\n" " 776 p->chunks[nchunks] = chunk_id;\n" @@ -31,4 +31,4 @@ "regards,\n" dan carpenter -8a5556290a5abbc1ef33b4dd2b2d8fc8f8a099f4aa1d98ddfe10f06baa4868a9 +187fd0270e50de16b55289420f2dc1d3e510251742aa66aad07fb84d94230c73
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.