From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Vipin Kumar <vipin.kumar@st.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
"tiwai@suse.de" <tiwai@suse.de>,
spear-devel <spear-devel@list.st.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH V3 3/4] ASoC: SPEAr spdif_out: Add spdif out support
Date: Sat, 30 Jun 2012 19:35:58 +0100 [thread overview]
Message-ID: <20120630183558.GB28922@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FED5AB1.6030907@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 422 bytes --]
On Fri, Jun 29, 2012 at 01:05:13PM +0530, Vipin Kumar wrote:
> On 6/28/2012 5:57 PM, Mark Brown wrote:
> >>+ .ops = (struct snd_soc_dai_ops *)&spdif_out_dai_ops,
> >Why do you need this cast?
> It was a const I think
So you've just introduced a bug, then - you're using a const variable in
a non-const context. Don't cast away the const, either arrange for the
ops pointer in the dai to be const or remove the const.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-06-30 18:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 7:01 [PATCH V3 0/4] Add support for STA529 codec, spdif_receiver and SPEAr spdif_out controller Rajeev Kumar
2012-06-28 7:01 ` [PATCH V3 1/4] ASoC: spdif_receiver: Add support for spdif in Audio Codec Rajeev Kumar
2012-06-28 12:15 ` Mark Brown
2012-06-28 7:01 ` [PATCH V3 2/4] ASoC: STA529: Add support for STA529 " Rajeev Kumar
2012-06-28 12:21 ` Mark Brown
2012-06-28 7:01 ` [PATCH V3 3/4] ASoC: SPEAr spdif_out: Add spdif out support Rajeev Kumar
2012-06-28 12:27 ` Mark Brown
2012-06-29 7:35 ` Vipin Kumar
2012-06-30 18:35 ` Mark Brown [this message]
2012-07-01 6:32 ` Vipin Kumar
2012-07-02 5:00 ` Rajeev kumar
2012-07-03 4:20 ` Rajeev kumar
2012-07-03 19:09 ` Mark Brown
2012-06-28 7:01 ` [PATCH V3 4/4] ASoC: SPEAr: Add Kconfig and Makefile to support SPEAr audio driver Rajeev Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120630183558.GB28922@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=rajeev-dlh.kumar@st.com \
--cc=spear-devel@list.st.com \
--cc=tiwai@suse.de \
--cc=vipin.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.