diff for duplicates of <20120701084540.GK4202@atomide.com> diff --git a/a/1.txt b/N1/1.txt index 10cea2f..dc8bfa3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,22 +18,22 @@ > > There are multiple bugs here that need to be addressed ... > > > > 1. Why the always-on power domain returns a context loss count of 1? This needs -> > to be fixed in the power domain code. However, the gpio driver should not -> > assume the loss count is 0 to begin with. +> > ? to be fixed in the power domain code. However, the gpio driver should not +> > ? assume the loss count is 0 to begin with. > Indeed. GPIO driver should not assume the value. > > > 2. The omap gpio driver should never be calling get_context_loss_count for a -> > gpio bank in a always-on domain. This is pointless and adds unneccessary -> > overhead. +> > ? gpio bank in a always-on domain. This is pointless and adds unneccessary +> > ? overhead. > Make sense too. > > > 3. The OMAP gpio driver assumes that the initial power domain context loss count -> > will be 0 at the time the gpio driver is probed. However, it could be -> > possible that this is not the case and an invalid context restore could be -> > performed during the probe. To avoid this otherwise only populated the -> > get_context_loss_count() function pointer after the initial call to -> > pm_runtime_get() has occurred. This will ensure that the first -> > pm_runtime_put() initialised the loss count correctly. +> > ? will be 0 at the time the gpio driver is probed. However, it could be +> > ? possible that this is not the case and an invalid context restore could be +> > ? performed during the probe. To avoid this otherwise only populated the +> > ? get_context_loss_count() function pointer after the initial call to +> > ? pm_runtime_get() has occurred. This will ensure that the first +> > ? pm_runtime_put() initialised the loss count correctly. > > > > This patch addresses issues 2 and 3 above. @@ -41,7 +41,3 @@ Should this one be Cc: stable? If this is a regression, then the regression causing commit should be mentioned. Tony --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 543e1ed..4ccdb4e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,18 +1,9 @@ "ref\01340990551-19426-1-git-send-email-jon-hunter@ti.com\0" "ref\0CAMQu2gx+tCujB0a+2zL8RGdJe5Y2VLPOyPUOPkys3VS7JdaKbg@mail.gmail.com\0" - "From\0Tony Lindgren <tony@atomide.com>\0" - "Subject\0Re: [PATCH] gpio/omap: fix invalid context restore of gpio bank-0\0" + "From\0tony@atomide.com (Tony Lindgren)\0" + "Subject\0[PATCH] gpio/omap: fix invalid context restore of gpio bank-0\0" "Date\0Sun, 1 Jul 2012 01:45:40 -0700\0" - "To\0Shilimkar" - " Santosh <santosh.shilimkar@ti.com>\0" - "Cc\0Jon Hunter <jon-hunter@ti.com>" - linux-omap <linux-omap@vger.kernel.org> - linux-arm <linux-arm-kernel@lists.infradead.org> - Grant Likely <grant.likely@secretlab.ca> - Linus Walleij <linus.walleij@stericsson.com> - Kevin Hilman <khilman@ti.com> - Tarun Kanti DebBarma <tarun.kanti@ti.com> - " Franky Lin <frankyl@broadcom.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120629 21:23]:\n" @@ -35,32 +26,28 @@ "> > There are multiple bugs here that need to be addressed ...\n" "> >\n" "> > 1. Why the always-on power domain returns a context loss count of 1? This needs\n" - "> > \302\240 to be fixed in the power domain code. However, the gpio driver should not\n" - "> > \302\240 assume the loss count is 0 to begin with.\n" + "> > ? to be fixed in the power domain code. However, the gpio driver should not\n" + "> > ? assume the loss count is 0 to begin with.\n" "> Indeed. GPIO driver should not assume the value.\n" "> \n" "> > 2. The omap gpio driver should never be calling get_context_loss_count for a\n" - "> > \302\240 gpio bank in a always-on domain. This is pointless and adds unneccessary\n" - "> > \302\240 overhead.\n" + "> > ? gpio bank in a always-on domain. This is pointless and adds unneccessary\n" + "> > ? overhead.\n" "> Make sense too.\n" "> \n" "> > 3. The OMAP gpio driver assumes that the initial power domain context loss count\n" - "> > \302\240 will be 0 at the time the gpio driver is probed. However, it could be\n" - "> > \302\240 possible that this is not the case and an invalid context restore could be\n" - "> > \302\240 performed during the probe. To avoid this otherwise only populated the\n" - "> > \302\240 get_context_loss_count() function pointer after the initial call to\n" - "> > \302\240 pm_runtime_get() has occurred. This will ensure that the first\n" - "> > \302\240 pm_runtime_put() initialised the loss count correctly.\n" + "> > ? will be 0 at the time the gpio driver is probed. However, it could be\n" + "> > ? possible that this is not the case and an invalid context restore could be\n" + "> > ? performed during the probe. To avoid this otherwise only populated the\n" + "> > ? get_context_loss_count() function pointer after the initial call to\n" + "> > ? pm_runtime_get() has occurred. This will ensure that the first\n" + "> > ? pm_runtime_put() initialised the loss count correctly.\n" "> >\n" "> > This patch addresses issues 2 and 3 above.\n" "\n" "Should this one be Cc: stable? If this is a regression, then the regression\n" "causing commit should be mentioned.\n" "\n" - "Tony\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Tony -19204d86a3868c02ca7a3e4a8418275279118c3ac89d8f6d94e927bea2bd840e +ac5982424cc2cb0abc830b8c236553079175423f430b1eafa338df6a257d998a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.