Re: [RFT] iwlegacy: don't mess up the SCD when removing a key

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Sun, Jul 01, 2012 at 04:07:03PM +0300, Emmanuel Grumbach wrote:
> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
> index d24eaf8..9981f09 100644
> --- a/drivers/net/wireless/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c
> @@ -3420,7 +3420,7 @@ il4965_remove_dynamic_key(struct il_priv *il,
>  	memset(&il->stations[sta_id].sta.key, 0, sizeof(struct il4965_keyinfo));
>  	il->stations[sta_id].sta.key.key_flags =
>  	    STA_KEY_FLG_NO_ENC | STA_KEY_FLG_INVALID;
> -	il->stations[sta_id].sta.key.key_offset = WEP_INVALID_OFFSET;
> +	il->stations[sta_id].sta.key.key_offset = keyconf->hw_key_idx;

Thanks for the patch. Just small issue with it. We use key_offset to
check if the key is invalid on the below code:

        if (il->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET) {
                IL_WARN("Removing wrong key %d 0x%x\n", keyconf->keyidx,
                        key_flags);
                spin_unlock_irqrestore(&il->sta_lock, flags);
                return 0;
        }

Since you changed the key_offset, above check should be changed as well,
probably using STA_KEY_FLG_INVALID flag.

Stanislaw