From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [RFC/PATCH] ASoC: dapm: Fix/add support for stereo widgets
Date: Mon, 2 Jul 2012 13:27:14 +0100 [thread overview]
Message-ID: <20120702122714.GE25093@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <134211720.502545.1341229602023.JavaMail.root@advansee.com>
[-- Attachment #1.1: Type: text/plain, Size: 786 bytes --]
On Mon, Jul 02, 2012 at 01:46:42PM +0200, Benoît Thébaudeau wrote:
> This patch:
> * adds a choice in snd_soc_dapm_get_volsw_mut() for stereo between 1 and 2
> registers, like in snd_soc_get_volsw().
> * fixes the missing stereo in other parts of dapm.
> * removes the unused saved_value from struct snd_soc_dapm_widget.
There's a couple of high level problems here.
One is that you've got multiple different things in a single commit
which isn't great practice for review, especially with such a vauge
changelog.
The other is that while you say that this "fixes the missing stereo in
other parts of dapm" I can't see any sign of any changes to (for
example) the path setup code which would seem to be essential for
supporting more than one channel in controls.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-07-02 12:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 20:41 [PATCH] ASoC: dapm: Fix snd_soc_dapm_put_volsw() connect Benoît Thébaudeau
2012-06-19 11:36 ` Mark Brown
2012-06-29 6:25 ` Takashi Iwai
2012-06-29 7:23 ` Mark Brown
2012-06-29 7:26 ` Takashi Iwai
2012-06-29 11:53 ` Benoît Thébaudeau
2012-06-29 12:03 ` Takashi Iwai
2012-06-29 14:29 ` Benoît Thébaudeau
2012-06-29 15:43 ` Takashi Iwai
2012-06-29 15:44 ` Takashi Iwai
2012-06-29 16:09 ` Benoît Thébaudeau
2012-06-29 16:22 ` Takashi Iwai
2012-06-29 19:09 ` Benoît Thébaudeau
2012-06-29 20:18 ` Benoît Thébaudeau
2012-06-30 11:39 ` Mark Brown
2012-06-30 13:03 ` Benoît Thébaudeau
2012-06-30 18:24 ` Mark Brown
2012-07-02 11:46 ` [RFC/PATCH] ASoC: dapm: Fix/add support for stereo widgets Benoît Thébaudeau
2012-07-02 12:27 ` Mark Brown [this message]
2012-07-03 6:57 ` [PATCH] ASoC: dapm: Fix snd_soc_dapm_put_volsw() connect Takashi Iwai
2012-06-30 11:38 ` Mark Brown
2012-06-29 16:05 ` Benoît Thébaudeau
2012-06-29 16:11 ` Takashi Iwai
2012-06-30 11:54 ` Mark Brown
2012-06-30 13:03 ` Benoît Thébaudeau
2012-07-02 11:45 ` [PATCH] ASoC: dapm: Fix dapm_set_path_status() connect Benoît Thébaudeau
2012-07-03 19:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702122714.GE25093@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=benoit.thebaudeau@advansee.com \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.