From: Josef Bacik <jbacik@fusionio.com>
To: Daniel J Blueman <daniel@quora.org>
Cc: "Chris L. Mason" <clmason@fusionio.com>,
Linux BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: Please hammer my for-linus branch
Date: Mon, 2 Jul 2012 09:34:46 -0400 [thread overview]
Message-ID: <20120702133446.GD6185@localhost.localdomain> (raw)
In-Reply-To: <CAMVG2stz6ED4D-YzST7V59jFsDS0gcB4cXrVd8ZTpXohRZh6Hw@mail.gmail.com>
On Sun, Jul 01, 2012 at 09:35:01PM -0600, Daniel J Blueman wrote:
> > Hi everyone,
> >
> > I've got a nice set of fixes from Josef, Jan, Ilya and others in my
> > for-linus branch:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus
> >
> > Some of the changes are fixes for the tree logging code, so I ran some
> > extra crash runs against them Friday night.
> >
> > I ended up with a new crash in the tree log directory deletion replay
> > code, so I didn't send out the pull request to Linus.
> >
> > It isn't clear yet if the new crash is because I was testing differently
> > or if it is a regression. I'm nailing it down this weekend, but please
> > give my for-linus a shot.
>
> With this branch (3.4.0), my test has consistently been hitting the
> BUG_ON(owner < BTRFS_FIRST_FREE_OBJECTID) in
> insert_inline_extent_backref [1]. This is followed by a string of
> other issues [2] and a hard lockup, so I used netconsole to collect
> this.
>
> I'm preparing my btrfs test for xfstests integration, but can slip you
> it if interested. It hits this case in ~30s.
>
Can you apply this and capture the output, I have a feeling I know what this is.
Thanks,
Josef
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 5775dc4..917ea70 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1766,7 +1766,13 @@ int insert_inline_extent_backref(struct btrfs_trans_handle *trans,
bytenr, num_bytes, parent,
root_objectid, owner, offset, 1);
if (ret == 0) {
- BUG_ON(owner < BTRFS_FIRST_FREE_OBJECTID);
+ if (owner < BTRFS_FIRST_FREE_OBJECTID) {
+ printk(KERN_ERR "bad inline extent, bytenr=%Lu, "
+ "num_bytes=%Lu, parent=%Lu, root=%Lu, owner=%Lu"
+ ", offset=%Lu\n", bytenr, num_bytes, parent,
+ root_objectid, owner, offset);
+ BUG_ON(owner < BTRFS_FIRST_FREE_OBJECTID);
+ }
update_inline_extent_backref(trans, root, path, iref,
refs_to_add, extent_op);
} else if (ret == -ENOENT) {
next prev parent reply other threads:[~2012-07-02 13:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 3:35 Please hammer my for-linus branch Daniel J Blueman
2012-07-02 4:20 ` Liu Bo
2012-07-10 12:18 ` Daniel J Blueman
2012-07-11 1:37 ` Liu Bo
2012-07-11 2:01 ` Daniel J Blueman
2012-07-02 13:34 ` Josef Bacik [this message]
2012-07-03 3:55 ` Daniel J Blueman
2012-07-04 3:37 ` Daniel J Blueman
2012-07-04 5:19 ` Liu Bo
2012-07-04 6:53 ` Daniel J Blueman
2012-07-05 13:26 ` Josef Bacik
2012-07-06 20:59 ` Josef Bacik
-- strict thread matches above, loose matches on Subject: below --
2012-07-01 1:22 Chris Mason
2012-07-02 20:17 ` Chris Mason
2012-07-03 14:39 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702133446.GD6185@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=clmason@fusionio.com \
--cc=daniel@quora.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.