From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fix up ilk rc6 disabling confusion
Date: Mon, 2 Jul 2012 18:49:43 +0200
Message-ID: <20120702164943.GD5064@phenom.ffwll.local>
References: <1341005536-5324-1-git-send-email-daniel.vetter@ffwll.ch>
	<20120630200444.71e4b92d@bwidawsk.net>
	<CAKMK7uHm8YN263M7oF+dn-Nt+EbcPSh7eL_LdUcGVRi1EuNR5A@mail.gmail.com>
	<20120702084400.478288aa@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id E45CB9E78F
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  2 Jul 2012 09:49:46 -0700 (PDT)
Received: by eaaf11 with SMTP id f11so2232505eaa.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 02 Jul 2012 09:49:46 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120702084400.478288aa@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jul 02, 2012 at 08:44:00AM -0700, Ben Widawsky wrote:
> On Sun, 1 Jul 2012 12:48:59 +0200
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Hm, I don't see the comment you're talking about ... Neither
> > ironlake_disable_rc6 nor ironlake_teardown_rc6 nor any of the callers
> > have one. Or am I totally missing your point?
> > -Daniel
> > 
> 
> iirc in the past, disabling rc6 mean disable, and destroy the object.
> Now it simply means disable. If that's the case, really just a comment
> in the commit would have made me happy. If it's not the case, ignore.

I think in the past disabl_rc6 meant disable&destroy on ilk, but disable
but not destroy on snb. I'll add a comment to the commit message to
mention that.
> 
> > >
> > >>
> > >> Also properly mark ironlake_enable_rc6 as static and kill the un-used
> > >> declaration in i915_drv.h.
> > >>
> > >> Cc: Ben Widawsky <ben@bwidawsk.net>
> > >> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Again,
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48