From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11 Date: Mon, 2 Jul 2012 16:58:27 +0000 Message-ID: <201207021658.27755.arnd@arndb.de> References: <4FECB95D.7010200@zytor.com> <20120701104401.GA4352@mail.gnudd.com> <2b797c83-6a3c-4051-841a-a4cfa9d1cae1@email.android.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.126.187]:61282 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755736Ab2GBR7K (ORCPT ); Mon, 2 Jul 2012 13:59:10 -0400 In-Reply-To: <2b797c83-6a3c-4051-841a-a4cfa9d1cae1@email.android.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: "H. Peter Anvin" Cc: Alessandro Rubini , linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com, alan@linux.intel.com, linux@arm.linux.org.uk, x86@kernel.org, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-arch@vger.kernel.org On Sunday 01 July 2012, H. Peter Anvin wrote: > > There is no problem with adding ARM or !X86 dependencies to drivers > now and fixing them later or as required. Right, but if the fix is trivial (e.g. missing #include statement), it's usually better to just fix the code. Also, in many cases it's possible to say specifically what some code depends on. E.g. if a driver uses clk_get/clk_put, it should depend on CLKDEV_LOOKUP, not on !X86. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 2 Jul 2012 16:58:27 +0000 Subject: [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11 In-Reply-To: <2b797c83-6a3c-4051-841a-a4cfa9d1cae1@email.android.com> References: <4FECB95D.7010200@zytor.com> <20120701104401.GA4352@mail.gnudd.com> <2b797c83-6a3c-4051-841a-a4cfa9d1cae1@email.android.com> Message-ID: <201207021658.27755.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sunday 01 July 2012, H. Peter Anvin wrote: > > There is no problem with adding ARM or !X86 dependencies to drivers > now and fixing them later or as required. Right, but if the fix is trivial (e.g. missing #include statement), it's usually better to just fix the code. Also, in many cases it's possible to say specifically what some code depends on. E.g. if a driver uses clk_get/clk_put, it should depend on CLKDEV_LOOKUP, not on !X86. Arnd