All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Perepechko <anserper@ya.ru>, linux-ext4@vger.kernel.org
Subject: Re: dead/wrong code in ext3/4_releasepage()
Date: Mon, 2 Jul 2012 14:17:20 -0400	[thread overview]
Message-ID: <20120702181720.GD5795@thunk.org> (raw)
In-Reply-To: <20120702173326.GL6679@quack.suse.cz>

On Mon, Jul 02, 2012 at 07:33:26PM +0200, Jan Kara wrote:
>   Hi,
> 
> On Mon 02-07-12 21:14:58, Andrew Perepechko wrote:
> > So you think the correct fix would be to remove the check completely
> > since every try_to_release_page() caller is obliged to perform the
> > page_has_private() check?
>   Yes, I think that would be reasonable. XFS already relies on this so
> it should be safe.

Andrew, can you send me a patch?

Thanks,

							- Ted

  reply	other threads:[~2012-07-02 18:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 16:52 dead/wrong code in ext3/4_releasepage() Andrew Perepechko
2012-07-02 17:09 ` Jan Kara
2012-07-02 17:14   ` Andrew Perepechko
2012-07-02 17:33     ` Jan Kara
2012-07-02 18:17       ` Theodore Ts'o [this message]
2012-07-02 18:19         ` Andrew Perepechko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120702181720.GD5795@thunk.org \
    --to=tytso@mit.edu \
    --cc=anserper@ya.ru \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.