From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mattia Dongili Subject: Re: gma500 suspend to ram fails (3.4) Date: Tue, 3 Jul 2012 07:11:32 +0900 Message-ID: <20120702221131.GA9260@kamineko.org> References: <20120618122629.54ad3c62@bob.linux.org.uk> <20120619105652.GA16280@kamineko.org> <20120620211925.GA12542@kamineko.org> <20120701220658.GB15883@kamineko.org> <20120702114304.1a8b390a@bob.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.kamineko.org (ac250205.ppp.asahi-net.or.jp [183.77.250.205]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E5C99E84C for ; Mon, 2 Jul 2012 15:11:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120702114304.1a8b390a@bob.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alan Cox Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Jul 02, 2012 at 11:43:04AM +0100, Alan Cox wrote: > On Mon, 2 Jul 2012 07:06:59 +0900 > Mattia Dongili wrote: ... > > a did put some printks here and there and psb_driver_init seems to > > never return from gma_backlight_init. > > Is it ok if you just comment out gma_backlight_init (at which point it > should just skip backlight handling and leave the firmware configured > one) ha! that gave me a good lead. The problem is not gma_backlight_init but rather psb_modeset_init that calls the errata for the chip that in turn sets the brightness before any initialization is done. Commenting out the call to dev_priv->ops->errata in framebuffer.c makes boot get to the end like it used to on 3.4. It seems to be just an ordering problem in the end. -- mattia :wq!