All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	shemminger@vyatta.com
Subject: long boot delays caused by 070ad7e7 floppy change
Date: Mon, 2 Jul 2012 15:46:48 -0700	[thread overview]
Message-ID: <20120702224648.GA20361@tassilo.jf.intel.com> (raw)

Jiri,

One of my test systems has a new 20s+ boot delay in 3.5rc*
It takes the floppy driver that long to determine I don't 
have a floppy

[    2.386322] calling  floppy_init+0x0/0xe46 @ 1
[    2.448977] Refined TSC clocksource calibration: 2594.106 MHz.
[    2.449021] Switching to clocksource tsc
[   22.371560] floppy0: no floppy controllers found
[   22.371676] initcall floppy_init+0x0/0xe46 returned -19 after 19553621 usecs

In older kernels the delay is only about 3s.

I tracked it down to 

commit 070ad7e793dc6ff753ee682ef7790b3373b471f6
Author: Jiri Kosina <jkosina@suse.cz>
Date:   Fri May 18 13:50:25 2012 +0200

    floppy: convert to delayed work and single-thread wq

The problem is not completely stable, a bisect actually doesn't
find it and reverting the patch on current HEAD also doesn't help.

However when setting the tree manually to one commit before
yours the problem is gone and adding your patch adds it.

I think the floppy init should run asynchronous, but it 
would be still good to make this faster again. Since block
devices need to be synchronized at end of boot there is no
way to hide a 20s delay completely.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

             reply	other threads:[~2012-07-02 22:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 22:46 Andi Kleen [this message]
2012-07-02 23:01 ` long boot delays caused by 070ad7e7 floppy change Linus Torvalds
2012-07-03 13:47   ` Calvin Walton
2012-07-03 17:07     ` Linus Torvalds
2012-07-03 17:40       ` Calvin Walton
2012-07-03 17:50         ` Linus Torvalds
2012-07-03 17:57           ` Jiri Kosina
2012-07-03 18:45             ` Andi Kleen
2012-07-03 17:58           ` Linus Torvalds
2012-07-03 18:15             ` Jiri Kosina
2012-07-03 18:58               ` Andi Kleen
2012-07-03 19:12                 ` Linus Torvalds
2012-07-03 19:36                   ` Calvin Walton
2012-07-03 19:42                     ` Andi Kleen
2012-07-03 20:05                     ` Linus Torvalds
2012-07-03 20:11                       ` Andi Kleen
2012-07-03 23:06                       ` Jiri Kosina
2012-07-03 19:40                   ` Andi Kleen
2012-07-03 23:01                     ` Linus Torvalds
2012-07-03 17:45       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120702224648.GA20361@tassilo.jf.intel.com \
    --to=andi@firstfloor.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.