From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
Date: Tue, 3 Jul 2012 10:28:57 +1000 [thread overview]
Message-ID: <20120703002857.GY19223@dastard> (raw)
In-Reply-To: <20120702100034.921366796@bombadil.infradead.org>
On Mon, Jul 02, 2012 at 06:00:05AM -0400, Christoph Hellwig wrote:
> xfs_bdstrat_cb only adds a check for a shutdown filesystem over xfs_buf_iorequest,
> but xfs_buf_iodone_callbacks just checked for a shut down filesystem a little
> earlier. In addition the shutdown handling in xfs_bdstrat_cb is not very suitable
> for this caller.
Makes sense - I have a patch locally that does this as part of a
xfs_buf_iorequest(bp, blkno, length) conversion to get rid of
XFS_BUF_SETADDR()....
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-03 0:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:00 [PATCH 0/2] buffer caches fixes for Linux 3.5 Christoph Hellwig
2012-07-02 10:00 ` [PATCH 1/2] xfs: prevent recursion in xfs_buf_iorequest Christoph Hellwig
2012-07-03 0:27 ` Dave Chinner
2012-07-02 10:00 ` [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks Christoph Hellwig
2012-07-03 0:28 ` Dave Chinner [this message]
2012-07-03 16:05 ` Christoph Hellwig
2012-07-03 23:29 ` Dave Chinner
2012-07-04 5:57 ` Christoph Hellwig
2012-07-04 8:32 ` Dave Chinner
2012-07-04 15:16 ` Christoph Hellwig
2012-07-12 23:04 ` Ben Myers
2012-07-13 6:16 ` Christoph Hellwig
2012-07-13 6:24 ` [PATCH 2/2 v2] " Christoph Hellwig
2012-07-13 16:59 ` Ben Myers
2012-07-13 19:12 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703002857.GY19223@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.