From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: linux-next: build failure after merge of the final tree (pwm tree related) Date: Tue, 3 Jul 2012 08:11:15 +0200 Message-ID: <20120703061115.GA27989@avionic-0098.mockup.avionic-design.de> References: <20120629174826.546cc991459b12833f2aaebd@canb.auug.org.au> <201206301920.21158.arnd.bergmann@linaro.org> <20120630194139.GA24300@avionic-0098.mockup.avionic-design.de> <201206302012.32476.arnd.bergmann@linaro.org> <20120701065639.GA25470@avionic-0098.adnet.avionic-design.de> <20120703154318.9e32d4a490c0b32e7d955ca4@canb.auug.org.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Return-path: Content-Disposition: inline In-Reply-To: <20120703154318.9e32d4a490c0b32e7d955ca4@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Rothwell Cc: Arnd Bergmann , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Sascha Hauer List-Id: linux-next.vger.kernel.org --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 03, 2012 at 03:43:18PM +1000, Stephen Rothwell wrote: > Hi all, >=20 > On Sun, 1 Jul 2012 08:56:39 +0200 Thierry Reding wrote: > > > > But if we make the new PWM symbol conflict with HAVE_PWM, then it'll do > > the right thing for any of the legacy PWM implementations, without > > having to track them down. Furthermore it'll also keep the legacy > > version by default and not allow the generic one to be enabled in that > > case. This is more likely to cause less side-effects than the other way > > around. > >=20 > > > One question though: if the generic pwm implementation does not set > > > HAVE_PWM, how can a driver check its presence? > >=20 > > The driver depends on PWM. HAVE_PWM is the symbol for the legacy > > implementations, while PWM is the new PWM API symbol. >=20 > I am still getting the mutliple definition errors from my powerpc > allyesconfg build. >=20 > $ grep PWM .config > CONFIG_TWL6030_PWM=3Dy > CONFIG_BACKLIGHT_PWM=3Dy > CONFIG_PWM=3Dy I don't see how that can happen. If you have CONFIG_TWL6030_PWM=3Dy, then you should also have CONFIG_HAVE_PWM=3Dy, which would in turn conflict with CONFIG_PWM=3Dy. I'll have to fetch a powerpc toolchain and try to reproduce this. Thierry --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJP8o0DAAoJEN0jrNd/PrOh1wEP/RIYM9bSnFt7as74fzSgK01v lTpbRiJmeHPDMfGF2k5sR0chxjmTW5uERjO8O7opqKjQtKqeWRtlfsJlA6B1pWN0 dDqVLE+XJlidBLbAwWoJUU1qPSjLHMmluBO43+dYvpuYrQb8V1FKbAlITrgP3zPq k3SIejeyUR1L+UyvsV4Lp9LaFU4iG7MJGTAfm3EDYoT9sAddg9LIjAOl5OgDGDqY 0w9SCJLAgMC1YFttNEVWMHJWf3z59odLq11E6hg/ShMRhkG6p4/brpbswJOrSMEn Nzyda23sAMSBQgu57J/9HZqtrRvZpnLPTNeMp5mso0Ffyqit4XDkrLxGEQnNZrGP TaPGrqr1Txcr97vZgMTisLfyMA4XrtF2xqxeWBdibWZGmgHhiEIjZ5UsdKS88EHa Z0pe7a6WR6rf/dE7I/gbkeokz5+acYKq8aT/HfItjYo5ajJuG1hRkgtxpdaIkwpM GoxaZ89rFp7ZAoAqlau3hQES49W0CnStwlFoIVK4CwF+icr0506WKVlT3pTDlZ1i aYcP4zlOXnPo4aeEC+MtHM1gT8jwUqK9un5xQxH+2WLBwxl+rbjyjNkCGJ8aximM VITil0bNO7WP0obdEXmff8keBahj7Zwftg+BYU8AWkekwoZaPcnwiBM2LUGNFGU2 OUe0+lsAKHCGF/MpPnUS =+wwd -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--