From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Wilson Subject: Re: pygrub: avoid problems if guest files are large etc. Date: Tue, 3 Jul 2012 09:07:41 -0700 Message-ID: <20120703160741.GB4332@US-SEA-R8XVZTX> References: <4FE4BB5F.5000103@citrix.com> <1340615266.3832.12.camel@zakaz.uk.xensource.com> <1340621572.3832.13.camel@zakaz.uk.xensource.com> <20120626001321.GC8088@US-SEA-R8XVZTX> <1341228154.4625.28.camel@zakaz.uk.xensource.com> <20120702194240.GA4332@US-SEA-R8XVZTX> <1341302944.4625.142.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1341302944.4625.142.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andrew Cooper , "xen-devel@lists.xen.org" , M A Young List-Id: xen-devel@lists.xenproject.org On Tue, Jul 03, 2012 at 01:09:04AM -0700, Ian Campbell wrote: > On Mon, 2012-07-02 at 20:42 +0100, Matt Wilson wrote: > > On Mon, Jul 02, 2012 at 04:22:34AM -0700, Ian Campbell wrote: > > > > > > > > Here is version 5 of my patch, modified following Matt Wilson's > > > > suggestions, standardizing the indentations, moving some of the clean up > > > > out of the loop, and reporting the actual error. > > > > > > Looks good to me. > > > > Me too. > > Can we take that as an > Acked-by: Matt Wilson > ? Sure, Acked-by: Matt Wilson > I'm holding off committing anything at the moment until we get a test > pass and a staging push. Probably a good idea. :-) Thanks! Matt