From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Rajeev Kumar <rajeev-dlh.kumar@st.com>
Cc: tiwai@suse.de, Vipin Kumar <vipin.kumar@st.com>,
alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH V4 2/2] ASoC: SPEAr spdif_out: Add spdif out support
Date: Tue, 3 Jul 2012 19:58:22 +0100 [thread overview]
Message-ID: <20120703185821.GZ29030@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <12728a82d749be9ee0a9de9d4d4dcb8d83a94bb5.1341312609.git.rajeev-dlh.kumar@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 486 bytes --]
On Tue, Jul 03, 2012 at 05:24:59PM +0530, Rajeev Kumar wrote:
> +static int spdif_out_mute;
This should be part of your driver data, not static data.
> +int spdif_soc_dai_probe(struct snd_soc_dai *dai)
> +{
> + struct snd_soc_card *card = dai->card;
> + struct snd_soc_pcm_runtime *rtd = card->rtd;
> + struct snd_soc_codec *codec = rtd->codec;
> +
> + return snd_soc_add_codec_controls(codec, spdif_out_controls,
> + ARRAY_SIZE(spdif_out_controls));
snd_soc_add_dai_controls().
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-07-03 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 11:54 [PATCH V4 0/2] Add support for sta529 audio codec and spdif_out controller Rajeev Kumar
2012-07-03 11:54 ` [PATCH V4 1/2] ASoC: STA529: Add support for STA529 Audio Codec Rajeev Kumar
2012-07-03 19:03 ` Mark Brown
2012-07-04 5:00 ` Rajeev kumar
2012-07-04 5:06 ` Rajeev kumar
2012-07-03 11:54 ` [PATCH V4 2/2] ASoC: SPEAr spdif_out: Add spdif out support Rajeev Kumar
2012-07-03 18:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703185821.GZ29030@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=rajeev-dlh.kumar@st.com \
--cc=tiwai@suse.de \
--cc=vipin.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.