From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: lrg@ti.com, grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: fixed: dt: support for input supply
Date: Tue, 3 Jul 2012 20:17:05 +0100 [thread overview]
Message-ID: <20120703191704.GE29030@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1341223645-7817-2-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
On Mon, Jul 02, 2012 at 03:37:25PM +0530, Laxman Dewangan wrote:
> + if (vin_supply)
> + drvdata->desc.supply_name = "vin";
> +
This isn't great both in terms of it being conditional and the fact that
it's only usable on DT systems as there's no non-DT way to do this. In
general unless we're working around some device tree issue (which should
be *very* rare) we shouldn't be adding any DT only stuff to generic
code, we need to be able to run Linux on non-DT systems.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-03 19:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:07 [PATCH 1/2] regulator: fixed: use devm_* for gpio request Laxman Dewangan
2012-07-02 10:07 ` Laxman Dewangan
2012-07-02 10:07 ` [PATCH 2/2] regulator: fixed: dt: support for input supply Laxman Dewangan
2012-07-02 10:07 ` Laxman Dewangan
2012-07-03 19:17 ` Mark Brown [this message]
2012-07-04 7:02 ` Laxman Dewangan
2012-07-04 10:21 ` Mark Brown
2012-07-04 10:42 ` Laxman Dewangan
[not found] ` <4FF41E2D.30104-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-04 10:58 ` Mark Brown
2012-07-04 10:58 ` Mark Brown
2012-07-02 17:29 ` [PATCH 1/2] regulator: fixed: use devm_* for gpio request Mark Brown
2012-07-03 8:48 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703191704.GE29030@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.