From: Jeff King <peff@peff.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [BUG] serious inflate inconsistency on master
Date: Wed, 4 Jul 2012 03:24:12 -0400 [thread overview]
Message-ID: <20120704072412.GC24807@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8AH6HHxE-P4j4O_VtVzz6-pe2VWk5ZayOfbZomfX2z7sg@mail.gmail.com>
On Wed, Jul 04, 2012 at 02:01:06PM +0700, Nguyen Thai Ngoc Duy wrote:
> On Wed, Jul 4, 2012 at 1:31 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
> >
> >> By the way I searched the commit that introduces that check with "git
> >> log --follow -p builtin/index-pack.c" but I could not find it. What
> >> did I do wrong?
> >
> > Your commit 8a2e163cc shows changes to the file at ll.535-540; these
> > come from 776ea370 builtin-index-pack.c ll.383-388.
> >
> > $ git show 776ea370:builtin-index-pack.c
>
> git newbie's hat's on. How do you find 776ea370, git-blame? Another
> question is why doesn't git-log show that commit?
I used git-blame to find it. As to your second question, I believe it is
one of the side-effects of the way --follow is bolted onto the revision
traversal. Look at:
gitk -- builtin/index-pack.c builtin-index-pack.c
and you will see that the commit in question happened on a simultaneous
branch with the big builtin rename commit. Since we process 776ea370
before we hit the rename commit, we do not yet realize that
builtin-index-pack.c is of interest to us.
-Peff
next prev parent reply other threads:[~2012-07-04 7:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 22:19 [BUG] serious inflate inconsistency on master Jeff King
2012-07-03 22:40 ` Junio C Hamano
2012-07-04 5:35 ` Nguyen Thai Ngoc Duy
2012-07-04 6:31 ` Junio C Hamano
2012-07-04 7:01 ` Nguyen Thai Ngoc Duy
2012-07-04 7:24 ` Jeff King [this message]
2012-07-04 7:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704072412.GC24807@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.