All of lore.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: md: fix up plugging (again). breaks build of the latest 3.5rc5+
Date: Wed, 4 Jul 2012 09:41:33 +1000	[thread overview]
Message-ID: <20120704094133.3f58fcf1@notabene.brown> (raw)
In-Reply-To: <4FF36732.3060306@mni.thm.de>

[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]

On Tue, 03 Jul 2012 23:42:10 +0200 Tobias Klausmann
<tobias.johannes.klausmann@mni.thm.de> wrote:

> Proposing this patch:
> 
> >From c6ac2740ed916ccf5b6fec0682101dd7a6a50f9f Mon Sep 17 00:00:00 2001
> From: Tobias Klausmann <tobias.klausmann@mni.thm.de>
> Date: Tue, 3 Jul 2012 23:03:43 +0200
> Subject: [PATCH] Fix patch md: fix up plugging again. Commit
>  b357f04a67c2aeee828b240863cd3f21d6cb3179
> 
> ---
>  drivers/md/raid10.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index acf5a82..8da6282 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -1394,7 +1394,7 @@ retry_write:
>  		bio_list_add(&conf->pending_bio_list, mbio);
>  		conf->pending_count++;
>  		spin_unlock_irqrestore(&conf->device_lock, flags);
> -		if (!mddev_check_plugged(mddev, 0, 0))
> +		if (!mddev_check_plugged(mddev))
>  			md_wakeup_thread(mddev->thread);
> 
>  		if (!r10_bio->devs[i].repl_bio)

Thanks.  That was careless.
I've posted a pull request so Linus can take either that or this.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2012-07-03 23:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 21:42 md: fix up plugging (again). breaks build of the latest 3.5rc5+ Tobias Klausmann
2012-07-03 23:41 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120704094133.3f58fcf1@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tobias.johannes.klausmann@mni.thm.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.