From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/7] ARM: shmobile: r8a7740: add basic pm domain support
Date: Wed, 04 Jul 2012 10:45:13 +0000 [thread overview]
Message-ID: <20120704104513.GB15679@linux-sh.org> (raw)
In-Reply-To: <87mx3gtc2d.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Jul 03, 2012 at 08:55:25PM -0700, Kuninori Morimoto wrote:
> +void r8a7740_init_pm_domain(struct r8a7740_pm_domain *r8a7740_pd)
> +{
> + struct generic_pm_domain *genpd = &r8a7740_pd->genpd;
> + struct dev_power_governor *gov = r8a7740_pd->gov;
> +
> + pm_genpd_init(genpd, gov ? : &simple_qos_governor, false);
> + genpd->dev_ops.stop = r8a7740_stop_dev;
> + genpd->dev_ops.start = r8a7740_start_dev;
> + genpd->dev_ops.active_wakeup = pd_active_wakeup;
> + genpd->dev_irq_safe = true;
> + genpd->power_off = pd_power_down;
> + genpd->power_on = pd_power_up;
> + __pd_power_up(r8a7740_pd, false);
> +}
> +
This pd_ naming really needs to go, it clashes too much with the generic
code and it is far more confusing than it needs to be. If this is an
r8a7740 specific routine then prefix with r8a7740 accordingly.
next prev parent reply other threads:[~2012-07-04 10:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 3:55 [PATCH 2/7] ARM: shmobile: r8a7740: add basic pm domain support Kuninori Morimoto
2012-07-04 10:45 ` Paul Mundt [this message]
2012-07-04 10:48 ` Magnus Damm
2012-07-04 16:57 ` Paul Mundt
2012-07-05 0:05 ` Kuninori Morimoto
2012-07-05 1:08 ` Kuninori Morimoto
2012-10-29 8:14 ` [PATCH 2/7] ARM: shmobile: r8a7740: add USB24 clock explain Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704104513.GB15679@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.