From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Wed, 04 Jul 2012 10:46:29 +0000 Subject: Re: [PATCH] ARM: shmobile: kzm9g: add REGULATOR settings to kzm9g_defconfig Message-Id: <20120704104629.GC15679@linux-sh.org> List-Id: References: <4FF2C282.5030000@kmckk.co.jp> In-Reply-To: <4FF2C282.5030000@kmckk.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Wed, Jul 04, 2012 at 07:41:09PM +0900, Magnus Damm wrote: > On Wed, Jul 4, 2012 at 7:38 PM, Mark Brown > wrote: > > On Wed, Jul 04, 2012 at 12:40:56PM +0200, Rafael J. Wysocki wrote: > > > >> Well, if arch-wide, then perhaps we don't need REGULATOR_FIXED_VOLTAGE at all > >> and we can just make things depending on it depend on REGULATOR directly? > > > >> The meaning of what you're proposing above is pretty much > >> "REGULATOR_FIXED_VOLTAGE should be set whenever REGULATOR is" and I guess > >> REGULATOR_FIXED_VOLTAGE depends on REGULATOR, so they appear to be equivalent. > > > >> How much code does really depend on REGULATOR_FIXED_VOLTAGE which is not build > >> when REGULATOR is set? > > > > No, that won't help - the problem is that we want a specific regulator > > driver to be built in order to ensure that the services it provides are > > available. > > Right, so what's wrong with having a "select REGULATOR_FIXED_VOLTAGE" > on boards that make use of them? That seems to be the most > straightforward way to me. > Yes, agreed. This is not very different from the gpiolib have/want case, either, and going that on a board-specific level worked out fine.