From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@stericsson.com>,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT] regulator: ab8500: Set enable enable_time in regulator_desc
Date: Wed, 4 Jul 2012 16:48:21 +0100 [thread overview]
Message-ID: <20120704154821.GG4111@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1341369105.10587.8.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Wed, Jul 04, 2012 at 10:31:45AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> Hi Linus,
> While working on this patch, I found in original code:
> ab8500_regulator_ops set enable_time callback to ab8500_regulator_enable_time,
> but does not set the delay in ab8500_regulator_info.
> I'm not sure the delay value is 0 for ab8500_regulator_ops, or the setting is
> just missing.
> Anyway, there is no behavior change by this patch.
Surely if the delay is not set in info then it'll introduce a delay
which wasn't there before (but which may well be a bug fix)?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-04 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 2:31 [PATCH RFT] regulator: ab8500: Set enable enable_time in regulator_desc Axel Lin
2012-07-04 15:48 ` Mark Brown [this message]
2012-08-06 15:46 ` Axel Lin
2012-08-06 15:50 ` Linus Walleij
2012-08-07 9:32 ` Linus Walleij
2012-08-07 10:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704154821.GG4111@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.