From: Alasdair G Kergon <agk@redhat.com>
To: lvm-devel@redhat.com
Subject: liblvm2app stripe_size reported wrong
Date: Wed, 4 Jul 2012 22:34:51 +0100 [thread overview]
Message-ID: <20120704213451.GO22022@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <201207041401.37385.benscott@nwlink.com>
On Wed, Jul 04, 2012 at 02:01:36PM -0700, ben wrote:
> Sector size is changing to a mix of 512 and 4k which will add to the confusion
> if it reports sectors.
Like in the kernel, we have a convention that sectors are always treated as 512
bytes.
commit 0bc382eae4cf77bdec9e5a2fdb11c72db64438bb
Author: Petr Rockai <prockai@redhat.com>
Date: Thu Nov 25 14:39:02 2010 +0000
All 'size' values of lvm2app properties should be in bytes.
Fix 'seg_size' to return bytes.
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
But if the assertion that all size values should be in bytes is true, why
did that patch only change one field and not these others?
Alasdair
prev parent reply other threads:[~2012-07-04 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 20:20 liblvm2app stripe_size reported wrong ben
2012-07-04 20:26 ` Alasdair G Kergon
2012-07-04 20:41 ` ben
2012-07-04 20:53 ` Alasdair G Kergon
2012-07-04 21:01 ` ben
2012-07-04 21:34 ` Alasdair G Kergon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704213451.GO22022@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.