From: Matt Wilson <msw@amazon.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v4] tools: honour --libdir when it is passed to ./configure
Date: Thu, 5 Jul 2012 10:05:29 -0700 [thread overview]
Message-ID: <20120705170529.GE4332@US-SEA-R8XVZTX> (raw)
In-Reply-To: <1341482501.16599.16.camel@zakaz.uk.xensource.com>
On Thu, Jul 05, 2012 at 03:01:41AM -0700, Ian Campbell wrote:
> On Thu, 2012-07-05 at 09:58 +0100, Ian Campbell wrote:
> > I'm going to revert the m4/default_lib.m4 and by extension the m4/pkg.m4
> > changes and commit the result (after consulting with Ian J to make sure
> > the test system can cope with this change).
>
> Having consulted with Ian I have now pushed the following:
Thanks for fixing this up, and for all the iterations on what should
have been a simple change.
Matt
> # HG changeset patch
> # User Matt Wilson <msw@amazon.com>
> # Date 1341482428 -3600
> # Node ID ad08cd8e7097ec6da6526cf8ac26f0fa72cd1e01
> # Parent 7c0351dc41a5123241af27f4cb910b915647193c
> tools: honour --libdir when it is passed to ./configure
>
> Currently shared libraries are automatically installed into /usr/lib
> or /usr/lib64, depending on the supplied --prefix value and
> $(XEN_TARGET_ARCH). Some systems, like recent Debian and Ubuntu releases,
> do not use /usr/lib64, but instead /usr/lib/x86_64-linux-gnu.
>
> With this change, packagers can supply the desired location for shared
> libraries on the ./configure command line. Packagers need to note that
> the default behaviour on 64-bit Linux systems will be to install shared
> libraries in /usr/lib, not /usr/lib64, unless a --libdir value is provided
> to ./configure.
>
> Additionally, the libfsimage plugins are now loaded explicitly from
> $LIBDIR/fs, removing platform-based decision trees in code.
>
> Signed-off-by: Matt Wilson <msw@amazon.com>
> Acked-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> [ ijc -- resolve rejects in configure by rerunning autogen.sh. Dropped changes
> to remove m4/default_lib.m4 and update m4/pkg.m4 since they cause LIBDIR=/lib
> instead of /usr/lib. Reran ./autogen.sh after that too ]
prev parent reply other threads:[~2012-07-05 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 18:18 [PATCH v4] tools: honour --libdir when it is passed to ./configure Matt Wilson
2012-07-05 8:58 ` Ian Campbell
2012-07-05 9:11 ` Roger Pau Monne
2012-07-05 10:01 ` Ian Campbell
2012-07-05 17:05 ` Matt Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705170529.GE4332@US-SEA-R8XVZTX \
--to=msw@amazon.com \
--cc=Ian.Campbell@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.