From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Wilson Subject: Re: [PATCH v4] tools: honour --libdir when it is passed to ./configure Date: Thu, 5 Jul 2012 10:05:29 -0700 Message-ID: <20120705170529.GE4332@US-SEA-R8XVZTX> References: <1341478690.31696.110.camel@zakaz.uk.xensource.com> <1341482501.16599.16.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1341482501.16599.16.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Roger Pau Monne , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, Jul 05, 2012 at 03:01:41AM -0700, Ian Campbell wrote: > On Thu, 2012-07-05 at 09:58 +0100, Ian Campbell wrote: > > I'm going to revert the m4/default_lib.m4 and by extension the m4/pkg.m4 > > changes and commit the result (after consulting with Ian J to make sure > > the test system can cope with this change). > > Having consulted with Ian I have now pushed the following: Thanks for fixing this up, and for all the iterations on what should have been a simple change. Matt > # HG changeset patch > # User Matt Wilson > # Date 1341482428 -3600 > # Node ID ad08cd8e7097ec6da6526cf8ac26f0fa72cd1e01 > # Parent 7c0351dc41a5123241af27f4cb910b915647193c > tools: honour --libdir when it is passed to ./configure > > Currently shared libraries are automatically installed into /usr/lib > or /usr/lib64, depending on the supplied --prefix value and > $(XEN_TARGET_ARCH). Some systems, like recent Debian and Ubuntu releases, > do not use /usr/lib64, but instead /usr/lib/x86_64-linux-gnu. > > With this change, packagers can supply the desired location for shared > libraries on the ./configure command line. Packagers need to note that > the default behaviour on 64-bit Linux systems will be to install shared > libraries in /usr/lib, not /usr/lib64, unless a --libdir value is provided > to ./configure. > > Additionally, the libfsimage plugins are now loaded explicitly from > $LIBDIR/fs, removing platform-based decision trees in code. > > Signed-off-by: Matt Wilson > Acked-by: Ian Jackson > Acked-by: Ian Campbell > [ ijc -- resolve rejects in configure by rerunning autogen.sh. Dropped changes > to remove m4/default_lib.m4 and update m4/pkg.m4 since they cause LIBDIR=/lib > instead of /usr/lib. Reran ./autogen.sh after that too ]