Re: [RFC PATCH 4/7] Btrfs: introduce subvol uuids and times

[Ilya Dryomov <idryomov@gmail.com>]

On Thu, Jul 05, 2012 at 09:18:41PM +0200, Alexander Block wrote:
> On Thu, Jul 5, 2012 at 9:01 PM, Zach Brown <zab@zabbo.net> wrote:
> > On 07/05/2012 11:59 AM, Ilya Dryomov wrote:
> >
> >> What if you are on a big-endian machine with a big-endian kernel and
> >> userspace?  Everything on-disk should be little-endian, so if you are
> >> going to write stuff you got from userspace to disk, at some point you
> >> have to make sure you are writing out bytes in the right order.
> >>
> >> Alex already does that, so my remarks are moot ;)
> >
> >
> > Yeah, indeed, we were only talking about the ioctl interface crossing
> > the user<->kernel barrier :).
> >
> I decided to not use __leXX variables in the new btrfs_ioctl_timespec
> structure because as most arguments found ioctls are currently in cpu
> dependent endianess. The kernel will then do the endianess conversion
> as it already did with struct timespec.

That's exactly the point of adding btrfs_ioctl_timespec instead of just
copying btrfs_timespec definition.

Thanks,

		Ilya