From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment
Date: Thu, 5 Jul 2012 22:55:29 +0200 [thread overview]
Message-ID: <201207052255.29490.marex@denx.de> (raw)
In-Reply-To: <CAA3CPjW3qvCBU0ycqE8OrjtQBuc15x+k_hyrmYDNun1FXBOGGA@mail.gmail.com>
Dear Ilya Yanok,
> Hi Marek,
>
> On Thu, Jul 5, 2012 at 11:58 PM, Marek Vasut <marex@denx.de> wrote:
> > > Yep. I even thought about this but decided not to do... can't recall
> > > why. Now I think it's really a good idea.
> > >
> > > > Maybe we should create DEFINE_ALIGNED_VARIABLE as a common.h macro?
> >
> > Like what's in common.h -- ALLOC_CACHE_ALIGN_BUFFER ?
>
> Yes, but for static variables and not hard-bound to ARCH_DMA_MINALIGN.
Good idea :)
> > > Hm.. Maybe. Ideas? ;) Actually I also thought about moving all this
> > > stuff to a single proper aligned buffer and do flush/invalidate for a
> > > whole buffer at once. It can save us some space... but it's BSS
> > > anyway... Don't know if it's worth it...
> >
> > But if you copy stuff back and forth, it'll cause performance hit.
>
> No, you talk about full bounce-buffering support and meant only one big
> buffer for internal structs.
Sure, but the internal structs can be aligned on their own, so there's no need
for a buffer.
> Regards, Ilya.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-05 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 13:03 [U-Boot] [PATCH] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment Ilya Yanok
2012-07-04 20:24 ` Marek Vasut
2012-07-05 18:44 ` Ilya Yanok
2012-07-05 19:58 ` Marek Vasut
2012-07-05 20:27 ` Ilya Yanok
2012-07-05 20:55 ` Marek Vasut [this message]
2012-07-05 17:15 ` Tom Rini
2012-07-05 18:25 ` Ilya Yanok
2012-07-05 18:47 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207052255.29490.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.