From: Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Herbert Xu <herbert@gondor.hengli.com.au>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: twofish-avx - remove useless instruction
Date: Fri, 6 Jul 2012 02:13:00 +0200 [thread overview]
Message-ID: <20120706001300.GF2091@kronos.redsun> (raw)
In-Reply-To: <20120705234612.GD29301@khazad-dum.debian.net>
On Thu, Jul 05, 2012 at 08:46:12PM -0300, Henrique de Moraes Holschuh wrote:
> Is it useless, or is it there to harden against some side-channel
> attack?
When writing this implementation, I first had a different approach with more
data getting read in and I just forgot to delete this instruction in the end.
The instruction didn't have any purpose regarding side-channel attacks. In the
decryption routine the instruction has been correctly deleted in the same
place.
next prev parent reply other threads:[~2012-07-06 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 18:43 [PATCH] crypto: twofish-avx - remove useless instruction Johannes Goetzfried
2012-07-05 18:43 ` Johannes Goetzfried
2012-07-05 23:46 ` Henrique de Moraes Holschuh
2012-07-05 23:46 ` Henrique de Moraes Holschuh
2012-07-06 0:13 ` Johannes Goetzfried [this message]
2012-07-11 3:26 ` Herbert Xu
2012-07-11 3:26 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706001300.GF2091@kronos.redsun \
--to=johannes.goetzfried@informatik.stud.uni-erlangen.de \
--cc=herbert@gondor.hengli.com.au \
--cc=hmh@hmh.eng.br \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.