From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Date: Fri, 6 Jul 2012 10:22:42 +0200 Message-ID: <20120706082242.GA1230@cmpxchg.org> References: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1341546297-6223-1-git-send-email-liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wanpeng Li Cc: Andrew Morton , Michal Hocko , KAMEZAWA Hiroyuki , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. And nobody is passing anything else. Which is easy to prove as this is a private function. And there wouldn't even be any harm passing something else. Please don't add stuff like this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx190.postini.com [74.125.245.190]) by kanga.kvack.org (Postfix) with SMTP id 63D706B0074 for ; Fri, 6 Jul 2012 04:22:55 -0400 (EDT) Date: Fri, 6 Jul 2012 10:22:42 +0200 From: Johannes Weiner Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Message-ID: <20120706082242.GA1230@cmpxchg.org> References: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: Andrew Morton , Michal Hocko , KAMEZAWA Hiroyuki , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. And nobody is passing anything else. Which is easy to prove as this is a private function. And there wouldn't even be any harm passing something else. Please don't add stuff like this. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932426Ab2GFIWz (ORCPT ); Fri, 6 Jul 2012 04:22:55 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:53488 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932083Ab2GFIWw (ORCPT ); Fri, 6 Jul 2012 04:22:52 -0400 Date: Fri, 6 Jul 2012 10:22:42 +0200 From: Johannes Weiner To: Wanpeng Li Cc: Andrew Morton , Michal Hocko , KAMEZAWA Hiroyuki , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Message-ID: <20120706082242.GA1230@cmpxchg.org> References: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. And nobody is passing anything else. Which is easy to prove as this is a private function. And there wouldn't even be any harm passing something else. Please don't add stuff like this.