All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: linux-mtd@lists.infradead.org
Cc: Marek Vasut <marex@denx.de>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	David Woodhouse <david.woodhouse@intel.com>
Subject: Re: [PATCH 3/3] [RFC] mtd: m25p80: Make fast read configurable via DT
Date: Fri, 6 Jul 2012 08:43:44 +0200	[thread overview]
Message-ID: <201207060843.45073.sr@denx.de> (raw)
In-Reply-To: <1341555027-17462-3-git-send-email-marex@denx.de>

Hi Marek,

On Friday 06 July 2012 08:10:27 Marek Vasut wrote:
> @@ -914,6 +912,14 @@ static int __devinit m25p_probe(struct spi_device
> *spi) flash->page_size = info->page_size;
>  	flash->mtd.writebufsize = flash->page_size;
> 
> +	flash->fast_read = false;
> +	if (np && of_find_property(np, "m25p,fast-read", NULL))
> +		flash->fast_read = true;
> +
> +#ifdef CONFIG_M25PXX_USE_FAST_READ
> +	flash->fast_read = true;
> +#endif
> +

Better use of_property_read_bool() instead of of_find_property() here.

Thanks,
Stefan

  reply	other threads:[~2012-07-06  6:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06  6:10 [PATCH 1/3] mtd: m25p80: add support for Spansion s25sl064p chip Marek Vasut
2012-07-06  6:10 ` [PATCH 2/3] mtd: m25p80: Fix the Spansion chip detection Marek Vasut
2012-07-06  6:10 ` [PATCH 3/3] [RFC] mtd: m25p80: Make fast read configurable via DT Marek Vasut
2012-07-06  6:43   ` Stefan Roese [this message]
2012-07-09  8:13   ` Marek Vasut
2012-07-11 14:38     ` Mike Frysinger
2012-07-13 10:44       ` Marek Vasut
2012-07-18 15:57 ` [PATCH 1/3] mtd: m25p80: add support for Spansion s25sl064p chip Artem Bityutskiy
2012-07-18 16:08   ` Marek Vasut
2012-07-18 16:07     ` Artem Bityutskiy
2012-07-18 16:13     ` Artem Bityutskiy
2012-07-22 23:58       ` Rob Herring
2012-07-23  1:00         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207060843.45073.sr@denx.de \
    --to=sr@denx.de \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=david.woodhouse@intel.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.