From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: Initialize the neighbour pointer of rt6_info on allocation
Date: Fri, 6 Jul 2012 11:16:28 +0200 [thread overview]
Message-ID: <20120706091628.GG1869@secunet.com> (raw)
In-Reply-To: <20120706065426.GF1869@secunet.com>
On Fri, Jul 06, 2012 at 08:54:26AM +0200, Steffen Klassert wrote:
> On Thu, Jul 05, 2012 at 05:16:44PM +0200, Eric Dumazet wrote:
> >
> > Hmm, could we find a way to avoid this for future changes ?
> >
> > We know dst_entry is the first field, so maybe :
> >
> > if (rt) {
> > struct dst_entry *dst = (struct dst_entry *)rt;
> >
> > memset(dst + 1, 0, sizeof(*rt) - sizeof(*dst));
> >
>
> Yes, I think we need to do something like this.
>
> I've just noticed that ip6_blackhole_route, xfrm_alloc_dst,
> dn_route_output_slow and dn_route_input_slow have the same issue.
Actually, decnet is ok. So I'll send patches with the change you
suggested for ipv6 and xfrm.
next prev parent reply other threads:[~2012-07-06 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 13:18 [PATCH net-next] ipv6: Initialize the neighbour pointer of rt6_info on allocation Steffen Klassert
2012-07-05 15:16 ` Eric Dumazet
2012-07-06 6:54 ` Steffen Klassert
2012-07-06 9:16 ` Steffen Klassert [this message]
2012-07-05 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706091628.GG1869@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.