From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dma: mxs-dma: Export missing symbols from mxs-dma.c
Date: Fri, 6 Jul 2012 19:10:21 +0800 [thread overview]
Message-ID: <20120706111020.GD12558@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <1341572992-12319-1-git-send-email-attila@kinali.ch>
On Fri, Jul 06, 2012 at 07:09:52PM +0800, Attila Kinali wrote:
> mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> which are used at least in mxs-mmc.c. Building mxs-mmc as module
> fails due to those two symbols not being exported.
>
> Signed-off-by: Attila Kinali <attila@kinali.ch>
> ---
> drivers/dma/mxs-dma.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index c96ab15..0437f49 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -201,6 +201,7 @@ int mxs_dma_is_apbh(struct dma_chan *chan)
>
> return dma_is_apbh(mxs_dma);
> }
> +EXPORT_SYMBOL(mxs_dma_is_apbh);
>
> int mxs_dma_is_apbx(struct dma_chan *chan)
> {
> @@ -209,6 +210,7 @@ int mxs_dma_is_apbx(struct dma_chan *chan)
>
> return !dma_is_apbh(mxs_dma);
> }
> +EXPORT_SYMBOL(mxs_dma_is_apbx);
>
Shawn,
Do we need this be EXPORT_SYMBOL_GPL?
> static void mxs_dma_reset_chan(struct mxs_dma_chan *mxs_chan)
> {
> @@ -779,3 +781,4 @@ static int __init mxs_dma_module_init(void)
> return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe);
> }
> subsys_initcall(mxs_dma_module_init);
> +
This line change is unneeded.
else i'm ok with the patch:
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-07-06 11:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 9:02 [PATCH] ARM: mxs: Export missing symbols from mxs-dma.c Attila Kinali
2012-07-06 10:52 ` Dong Aisheng
2012-07-06 11:09 ` [PATCH] ARM: dma: mxs-dma: " Attila Kinali
2012-07-06 11:10 ` Dong Aisheng [this message]
2012-07-06 11:19 ` Attila Kinali
2012-07-06 11:22 ` Attila Kinali
2012-07-06 11:17 ` Dong Aisheng
2012-07-06 12:21 ` Shawn Guo
2012-07-06 12:53 ` [PATCH] " Attila Kinali
2012-07-06 13:45 ` Shawn Guo
2012-07-16 6:30 ` Vinod Koul
2012-07-16 9:19 ` Attila Kinali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706111020.GD12558@shlinux2.ap.freescale.net \
--to=b29396@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.