All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Avi Kivity <avi@redhat.com>,
	linux-kernel@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] kvm, Add x86_hyper_kvm to complete detect_hypervisor_platform check [v2]
Date: Fri, 6 Jul 2012 08:27:19 -0300	[thread overview]
Message-ID: <20120706112719.GA18059@amt.cnet> (raw)
In-Reply-To: <4FF5987C.6080905@redhat.com>

On Thu, Jul 05, 2012 at 09:37:00AM -0400, Prarit Bhargava wrote:
> 
> 
> On 07/05/2012 09:26 AM, Avi Kivity wrote:
> > Please copy at least kvm@vger.kernel.org, and preferably Marcelo as well
> > (the other kvm co-maintainer).
> > 
> > 
> 
> While debugging I noticed that unlike all the other hypervisor code in the
> kernel, kvm does not have an entry for x86_hyper which is used in
> detect_hypervisor_platform() which results in a nice printk in the
> syslog.  This is only really a stub function but it
> does make kvm more consistent with the other hypervisors.
> 
> [v2]: add detect and _GPL export
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: Avi Kivity <avi@redhat.com>
> Cc: Gleb Natapov <gleb@redhat.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Looks good, please regenerate:

Hunk #1 FAILED at 39.
Hunk #2 succeeded at 484 (offset 51 lines).
1 out of 2 hunks FAILED -- saving rejects to file
arch/x86/kernel/kvm.c.rej

  reply	other threads:[~2012-07-06 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 13:11 [PATCH 0/2] hypervisor, update hypervisor_x86 entries for kvm and xen Prarit Bhargava
2012-07-05 13:11 ` [PATCH 1/2] kvm, Add x86_hyper_kvm to complete detect_hypervisor_platform check [v2] Prarit Bhargava
2012-07-05 13:26   ` Avi Kivity
2012-07-05 13:37     ` Prarit Bhargava
2012-07-06 11:27       ` Marcelo Tosatti [this message]
2012-07-06 17:47         ` Prarit Bhargava
2012-07-11 16:34           ` Avi Kivity
2012-07-05 13:11 ` [PATCH 2/2] xen, fix x86_hyper_xen_hvm symbol export Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706112719.GA18059@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.