All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Remove unused CONFIG_STACKSIZE
Date: Fri, 6 Jul 2012 13:17:43 +0200	[thread overview]
Message-ID: <20120706131743.42e05afc@aari01-12> (raw)
In-Reply-To: <4FF607A3.5000106@gmail.com>

Hi Rob,

On Thu, 05 Jul 2012 16:31:15 -0500, Rob Herring <robherring2@gmail.com>
wrote:
> Albert,
> 
> On 07/05/2012 05:10 AM, Albert ARIBAUD wrote:
> > Hi Rob,
> > 
> > On Thu, 28 Jun 2012 08:54:10 -0500, Rob Herring
> > <robherring2@gmail.com> wrote:
> >> From: Rob Herring <rob.herring@calxeda.com>
> >>
> >> CONFIG_STACKSIZE is not referenced anywhere except on AVR32, but
> >> present in most ARM boards. The IRQ and FIQ stacks are not setup in
> >> start.S, but arch/arm/lib/board.c, so also remove those comments.
> > 
> > Not sure I understand the last point. Can you clarify? How does this
> > relate to keeping FIQ / IRQ stack size declarations in config files?
> > E.g.:
> 
> The irq and fiq stack sizes are setup in arch/arm/lib/board.c, not
> start.S as the comment suggested.
> 
> There's only 2 boards that turn on USE_IRQ and I'm not convinced they
> would actually work after a brief look. Perhaps we should just remove
> all the defines except from those 2 boards.

I would appreciate indeed it if these unused defines were removed.

Whether the two boards which actually use IRQs would work or not is a
separate issue which board maintainers or users should handle if they
want to.

> Rob

Amicalement,
-- 
Albert.

  reply	other threads:[~2012-07-06 11:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 13:54 [U-Boot] [PATCH 1/2] Remove unused CONFIG_STACKSIZE Rob Herring
2012-07-05 10:10 ` Albert ARIBAUD
2012-07-05 21:31   ` Rob Herring
2012-07-06 11:17     ` Albert ARIBAUD [this message]
2012-07-13 19:44 ` [U-Boot] [PATCH v2] ARM: Remove unused stack and irq config defines Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706131743.42e05afc@aari01-12 \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.