All of lore.kernel.org
 help / color / mirror / Atom feed
From: wfg@linux.intel.com
To: kernel-janitors@vger.kernel.org
Subject: [random:dev 2/9] drivers/char/random.c:682:62: sparse: Using plain integer as NULL pointer
Date: Fri, 06 Jul 2012 17:31:17 +0000	[thread overview]
Message-ID: <20120706173117.GA21914@localhost> (raw)

Hi Theodore,

Some trivial sparse warnings :)

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tytso/random.git dev
head:   0ca6c546645d39d68e67b70e5c8f00ad9a955fcb
commit: 4d5ecd27a003dbdecfbaca413803c7d6723cc1d4 [2/9] random: use lockless techniques in the interrupt path

All sparse warnings:

  drivers/char/random.c:287:8: sparse: symbol 'trickle_count' was not declared. Should it be static?
+ drivers/char/random.c:682:62: sparse: Using plain integer as NULL pointer
  drivers/char/random.c:739:8: sparse: symbol 'irq_randomness' was not declared. Should it be static?
  drivers/char/random.c:766:72: sparse: Using plain integer as NULL pointer
  drivers/char/random.c:818:47: sparse: Using plain integer as NULL pointer
  drivers/char/random.c:1027:46: sparse: Using plain integer as NULL pointer
  drivers/char/random.c:1031:52: sparse: Using plain integer as NULL pointer
  drivers/char/random.c:1033:60: sparse: Using plain integer as NULL pointer
  drivers/char/random.c:1170:47: sparse: Using plain integer as NULL pointer
  drivers/char/random.c:1332:11: sparse: symbol 'random_table' was not declared. Should it be static?
  drivers/char/random.c:1397:1: sparse: symbol '__pcpu_scope_get_random_int_hash' was not declared. Should it be static?
  drivers/char/random.c:1397:1: sparse: symbol 'get_random_int_hash' was not declared. Should it be static?

vim +682 drivers/char/random.c
   679			sample.cycles = get_cycles();
   680	
   681		sample.num = num;
 > 682		mix_pool_bytes(&input_pool, &sample, sizeof(sample), 0);
   683	
   684		/*
   685		 * Calculate number of bits of randomness we probably added.

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

             reply	other threads:[~2012-07-06 17:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06 17:31 wfg [this message]
2012-07-06 18:07 ` [random:dev 2/9] drivers/char/random.c:682:62: sparse: Using plain integer as NULL pointer Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706173117.GA21914@localhost \
    --to=wfg@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.